[issue17511] Idle find function closes after each find operation

New submission from Sarah: When I use the 'find' function in Idle, the dialogue closes after the first instance is found. To find the next instance, one must then use the 'find again' function, rather than the 'find' function. One can also use Ctrl+G, but that may not be intuitive for new use

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I can confirm this behavior. The attached preliminary patch allows the Find dialog to remain open, and is the same for 2.x and 3.x. Until PEP434 gets resolved, I won't be able to apply the patch for earlier versions of IDLE. For what it's worth, the applied patch

[issue17511] Idle find function closes after each find operation

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17511] Idle find function closes after each find operation

Todd Rovito added the comment: If it helps I have confirmed that this patch works great on Python 3.4 and Python 2.7 on the Mac. The code looks very clean and provides a simple fix. -- ___ Python tracker

[issue17511] Idle find function closes after each find operation

Kuchinsky added the comment: Thanks, Roger. Unfortunately, this doesn't work for me. I'm running Windows and am using version 2.7.3 For me, nothing is highlighted until the 'find' window closes. This means that if I click 'find', nothing is highlighted even though the text has been found. F

[issue17511] Idle find function closes after each find operation

Kuchinsky added the comment: I think I fixed it! I used some of the code from ReplaceDialog.py to get the highlighted text to display. Thanks to Roger for mentioning that file! Since the find function now does 'find again', we might want to remove the 'find again' option from the 'Edit' menu.

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: (I didn't realize that the patch is identical to the one submitted on issue13586). The issue with the found text not being highlighted is Windows-specific. Issue13630 discusses that particular problem and it has the same root cause as issue14146. Changing the

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: Update for what I wrote in msg185101: The behavior introduced in #13052 which kept the replace dialog open has been reverted by #17625. There ought to be consistency across the different find/replace dialogs. The replace dialog closes when clicking "close" or "r

[issue17511] Idle find function closes after each find operation

Sarah added the comment: This should allow the 'find' window to stay open. It also circumvents an issue in Windows, wherein highlighted text did not show while the 'find' window was open. The found text should now show as highlighted for any OS (as far as I know; please test). When the find wi

[issue17511] Idle find function closes after each find operation

Todd Rovito added the comment: "I am in support of letting the find dialog remain open, and possibly relabeling the button to say "find next" instead." +1 from me, it drives me nuts to have the dialog close every time a single world is found. I like the find dialog box open then I just escape

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: Every other editor I can remember does 'find next'. The current closing annoys me. Also, I prefer wrapping around to the top when the last item is found, rather than having to switch to find [x]up. Windows help does this. -- __

[issue17511] Idle find function closes after each find operation

Sarah added the comment: This changes the button's text from "Find" to "Find Again", as per Todd Rovito and Terry J. Reedy's suggestion. -- Added file: http://bugs.python.org/file29735/issue17511_FindAgain.patch ___ Python tracker

[issue17511] Idle find function closes after each find operation

Sarah added the comment: Terry- There should be a checkbutton option labeled 'Wrap Around'. This is instantiated on lines 7 and 105-111 of SearchDialogBase.py Admittedly, it is standard practice to have a 'find' function wrap around. I suppose we could have the dialog start up with the 'Wrap

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: 'Find Next' is the actual (and standard) suggestion. It s a trivial change given that you identified the place to make it . -- ___ Python tracker _

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: I took a look at both the 'Search' and 'Replace' dialogs and both already have wrap-around present as the default: '[x] Wrap around'. Sorry for not checking earlier. Having the find window stay open will make it much easier to visually check all the options.

[issue17511] Idle find function closes after each find operation

Sarah added the comment: 'Find Again' switched to 'Find Next' -- Added file: http://bugs.python.org/file29740/issue_17511_FindNext.patch ___ Python tracker ___ __

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I tried the patch against 2.7 and it appears to work, but might introduce another interface problem. The search dialog opens up as a modal window which disallows the user from changing the text. This may or may not be desirable. The technique of using the "hit"

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: The modal versus non-modal issue, plus the Windows hi-lite issue, may partly explain the current design. It is actually quite usable once understood. The problem is that the current sparse doc does not adequately explain the intention - use ^F once to set the

[issue17511] Idle find function closes after each find operation

Sarah added the comment: I agree that discussion is a good idea. Personally, though, I don't want to make the user hit ^F once to set the key and use ^G to find it again. It works well and, for a more advanced user, is great, but it adds to what a user must learn to get up and running in Pyth

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I submitted a patch to #14146 that would work around the selection highlighting issue on Windows. It is based on Sarah's idea of replacing the "sel" tags with a tag that remains visible. There are a lot of ideas floating here about improving the search dialog. Ma

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: issue_17511_FindNext_rev1.patch keeps the find dialog open and changes the button from "Find" to "Find Next". The applied patch from #14146 corrects the selection tag highlighting issue. -- Added file: http://bugs.python.org/file30329/issue_17511_FindNext

[issue17511] Idle find function closes after each find operation

Todd Rovito added the comment: I was wondering does it make sense to commit this patch since it is similar to http://bugs.python.org/issue14146 then put the issue in the pending state as we wait for the TK/TCL fix? It seems more consistent to me since this issue is basically the same highligh

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I debated whether or not to leave #14146 as pending or to close it out altogether. I'd rather not let the design decisions of Tk dictate inconsistent cross-platform behavior for IDLE, but I'm willing to hear Tk's rationale and possible fix for that problem. I wo

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: I closed #14146. Same comment will apply here once this is committed. I would like to try the latest patch here before that, and will try to do so tomorrow. I agree with trying to be consistent across platforms. I am pretty sure that use of multiple personal c

[issue17511] Idle find function closes after each find operation

Roundup Robot added the comment: New changeset 73de0794ae71 by Roger Serwy in branch '2.7': #17511: Keep IDLE find dialog open after clicking "Find Next". http://hg.python.org/cpython/rev/73de0794ae71 New changeset dac11f143581 by Roger Serwy in branch '3.3': #17511: Keep IDLE find dialog open a

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I'm closing this issue as fixed. Thank you for the patch, Sarah. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker