[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Mark Lawrence added the comment: Just a prod in case it has gone under the radar. -- nosy: +BreamoreBoy versions: +Python 3.2 -Python 2.7 ___ Python tracker ___ __

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file8115/urllib2-301-cache.patch ___ Python tracker ___ ___ Python-bugs-li

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file8116/test_urllib2-cache.patch ___ Python tracker ___ ___ Python-bugs-l

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file8117/liburllib2.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file15722/urllib2-301-redirection-CORRECTED.diff ___ Python tracker ___ _

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file15745/urllib2-301-redirection-proper.diff ___ Python tracker ___ ___

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: Attaching a non-malformed patch. I had incomplete tests in previous ones and I removed it by-hand before submitting for review. Something went wrong, I see. Okay, I get the points you are making. Specifically a request specific object and then maintaining a

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

John J Lee added the comment: > Yes,it currently does not handle chained redirects via cache. I dont know > RFC's stance on it. RFC does not say anything about 301 chained redirects I don't see anything in the RFC that prevents us caching chained 301 redirections. Caching the chained redirec

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

John J Lee added the comment: To make sure I understood something Antoine said: By "per-request", I assume you mean the same kind of thing as the current use of .redirect_dict -- the multiple urllib2.Request instances that may result from a single request passed by the user to .open()/urlope

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: Thanks for the comments. Shall come with the tests. Yes,it currently does not handle chained redirects via cache. I dont know RFC's stance on it. RFC does not say anything about 301 chained redirects and there are tricker issues of caching anything other th

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Antoine Pitrou added the comment: Well, first it would be better with some tests. Second, what does it do for chained redirects? E.g. let's say that there's a chain of 301 redirects: A --> B --> C. Does it cache the whole A --> C mapping, or only A --> B? If the latter, will the chaining occu

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: Antoine: I got your point. Yes, I was missing the purpose of the redirection itself and the patch was wrong. If the 301 is to be cached, the cache map should be maintained at the higher level in order for the further requests to refer to. I have created a re

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Antoine Pitrou added the comment: > Here is the corrected patch for caching the 301 redirections. > > * It caches only the redirection not the response. > * It retains cacheable=True kwarg for http_error_301 method. ( I feel, it > should be useful) > * Have made the cached dict as private. I'

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil Kumaran : Removed file: http://bugs.python.org/file15677/urllib2-301-redirection.diff ___ Python tracker ___ ___ Python-b

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: Here is the corrected patch for caching the 301 redirections. * It caches only the redirection not the response. * It retains cacheable=True kwarg for http_error_301 method. ( I feel, it should be useful) * Have made the cached dict as private. I have update

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

R. David Murray added the comment: I haven't reviewed the patch, but I would like the caching behavior to be settable. I can easily imagine a use case where I would not want the URLs cached: when using urllib in a test suite or test tool. (I just ran into this problem trying to use firefox as

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: > Antoine Pitrou added the Comment: > > I have trouble understanding what the patch does. I would expect it to > cache the -> mapping, but it

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Antoine Pitrou added the comment: I have trouble understanding what the patch does. I would expect it to cache the -> mapping, but it seems to cache the final HTTP response instead. Also, it's not obvious in which situations the default for `cacheable` would be overriden. Aren't http_error_30

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Senthil Kumaran added the comment: I am attaching an updated patch for caching the 301 redirects. As per RFC 2616: 10.3.2 301 Moved Permanently ... ...references returned by the server, where possible. This response is cacheable unless indicated otherwise. So, I have included an additio

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Senthil : -- assignee: -> orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by Daniel Diniz : -- nosy: +jjlee stage: -> patch review type: -> feature request versions: +Python 2.7 -Python 2.6 ___ Python tracker ___ ___

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

Changes by vila: -- nosy: +vila _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o