Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
This fix introduces other bug (see issue17838). I think this fix with
issue17838 fix should be included in next regression releases.
--
nosy: +benjamin.peterson, georg.brandl, larry
priority: critical - release blocker
status: closed - open
versions:
Antoine Pitrou added the comment:
Yes, fixing site.py is fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 99e363e67844 by Roger Serwy in branch '2.7':
#17585: Fixed IDLE regression. Now closes when using exit() or quit().
http://hg.python.org/cpython/rev/99e363e67844
New changeset d3c67e2fc68c by Roger Serwy in branch '3.3':
#17585: Fixed IDLE
Roger Serwy added the comment:
Thanks, Antoine.
I am closing this issue as fixed.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
Roger Serwy added the comment:
Serhiy, don't worry. There's still plenty of broken found in IDLE.
Antoine, may I modify site.py with site_reversion.patch? If not, then I can
include a workaround in IDLE.
--
___
Python tracker rep...@bugs.python.org
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Perhaps PseudoInputFile.close() should call super().close() to set closed flag.
Perhaps close() should be even implemented in PseudoFile.
It's my fault in this regression. I deliberately have not implemented
PseudoFile.close(), because I saw no sense in
New submission from Roger Serwy:
This issue is a split from #5492, where Terry noticed a serious regression that
quit() and exit() no longer work in IDLE.
Before #9290, the PyShell object itself was stdin and it didn't have a fileno
method. The code in site.py would skip over the call to
Terry J. Reedy added the comment:
I thought of this exact patch, but then decided against it.
1. The bug is in site.py -- see thread
[Python-Dev] Idle, site.py, and the release candidates
for a better explanation and solution.
2. The Idle behavior, inherited from io.IOBase is correct.
3. The
Roger Serwy added the comment:
I agree that site.py's Quitter exception logic has a flaw as described on the
email from python-dev. But I disagree that the problem of IDLE not exiting is
due to site.py. Even if you fix site.py (which I did), calling
sys.stdin.close() won't close IDLE since
Terry J. Reedy added the comment:
I see that now. Then both files should be fixed. I still object to introducing
a buggy .fileno ;-).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
Roger Serwy added the comment:
Terry, I agree that the original patch introduces a buggy fileno and it knows
too much about the internals of site.py which could change.
The attached patch modifies site.py, similar to how Nick Coghlan split the two
function calls in a single try/except block
Antoine Pitrou added the comment:
Please read http://mail.python.org/pipermail/python-dev/2013-March/125021.html
. The fileno() check shouldn't be needed anymore.
Also, it can't effect 2.7, or you have another problem.
--
nosy: +pitrou
versions: -Python 2.7, Python 3.2
Antoine Pitrou added the comment:
(s/effect/affect/, sorry)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list
Roger Serwy added the comment:
Antoine, it does affect 2.7 since sys.stdin.close() doesn't call PyShell's
close method. #9290 introduced this regression. I accept some responsibility
because my manual testing of those patches in #9290 didn't include trying the
exit() and quit() methods.
The
Roger Serwy added the comment:
I would also argue that the fileno_close.patch ought to be applied to the 3.2.4
and 3.3.1 release candidates. The changes in #9290 were applied only two months
ago.
--
versions: +Python 3.2
___
Python tracker
Antoine Pitrou added the comment:
I won't argue about any changes in IDLE, but the fileno-checking code in
site.py should probably be removed, not complicated.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
Roger Serwy added the comment:
I agree with Antoine that fileno checking code should be removed. I dug deeper
into why that was introduced in the first place.
00b136b7da84 introduced the warning Trying to close unclosable fd!
86358b43c8bb intoduced the change to site.py about not closing stdin
20 matches
Mail list logo
