Roundup Robot added the comment:
New changeset 07a615a8f9ad by Brett Cannon in branch '3.5':
Issue #17633: Improve support for namespace packages with zipimport.
https://hg.python.org/cpython/rev/07a615a8f9ad
New changeset 87f87673af7b by Brett Cannon in branch 'default':
Merge for issue #17633
Brett Cannon added the comment:
The fix for 3.5 is in https://hg.python.org/cpython/rev/07a615a8f9ad and 3.6 in
https://hg.python.org/cpython/rev/87f87673af7b.
Thanks to Phil and Mike for tackling this problem!
--
resolution: -> fixed
stage: patch review -> resolved
status: open ->
Mike Romberg added the comment:
This patch modifies issue17633-hg.diff by adding changes suggested by the
reviewers.
Note. I did cleanup the use of __import__ outside of the area involved with
issue17633 as it seemed low risk. The tests for issue17633 (and the refactored
doTest/makeZip
Mike Romberg added the comment:
Yes. I can do this. I've not used hg before. But I bet I can figure it out.
I'm assuming hg has a diff/pach genterator of some kind ('hg diff' perhaps).
Lemme try and find the hg repository and check out a copy...
--
Mike Romberg added the comment:
Try issue17633-hg.diff. Caution it was made after literally minutes of
experience with hg. :)
I checked out the source applied the changes, compiled and ran 'make test'
(gdb still fails), and did an hg commit. The diff was made following the
instructions
Brett Cannon added the comment:
Any chance you can do the diff against an hg checkout, Mike? That way we can
use our review tool to do the code review, else we have to work only from the
raw diff file which isn't as nice.
--
___
Python tracker
Brett Cannon added the comment:
Nope, looks like it worked! I will try to have a look at the patch some time
this week.
And for future reference, you can also use
https://docs.python.org/devguide/patch.html as a guide.
--
assignee: -> brett.cannon
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +gregory.p.smith, superluser
versions: +Python 3.6 -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Eric V. Smith e...@trueblade.com:
--
keywords: +needs review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Thomas Heller thel...@ctypes.org:
--
nosy: +theller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29696/test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Phil Connell added the comment:
The attached patch is ready for review.
--
Added file: http://bugs.python.org/file29925/issue17633.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Phil Connell added the comment:
Updated patch with markups suggested by Serhiy.
--
Added file: http://bugs.python.org/file29927/issue17633-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Phil Connell pconn...@gmail.com:
Added file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Phil Connell added the comment:
Here's a test that fails without the patch and succeeds with the patch.
--
Added file: http://bugs.python.org/file29696/test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
New submission from Phil Connell:
Only one level of namespace package nesting is handled correctly:
$ unzip -l foo.zip
Archive: foo.zip
Length DateTimeName
- -- -
0 2013-04-03 17:28 a/b/c/foo.py
0 2013-04-03 17:34 a/
0
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
___
Python-bugs-list
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
___
Python-bugs-list
Eric V. Smith added the comment:
Could you construct a test (that would fail without your patch)?
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
23 matches
Mail list logo
