Changes by Markus bela domla...@yahoo.com:
--
components: +Windows -Library (Lib), Unicode
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Changes by Benjamin Peterson benja...@python.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Serhiy Storchaka added the comment:
Shouldn't it left opened until regression fix release has released.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Antoine Pitrou added the comment:
I don't think so. The bug is fixed, and the fix will be in the release.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Arfrever Frehtes Taifersar Arahesis added the comment:
http://mail.python.org/pipermail/python-dev/2013-April/125761.html asked to
leave bugs open.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
Antoine Pitrou added the comment:
Ah, fair enough.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Roundup Robot added the comment:
New changeset 8952fa2c475f by Serhiy Storchaka in branch '2.7':
Issue #17656: Skip test_extract_unicode_filenames if the FS encoding
http://hg.python.org/cpython/rev/8952fa2c475f
--
___
Python tracker
Serhiy Storchaka added the comment:
Sorry, I thought I had corrected this test.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Python-bugs-list
Charles-François Natali added the comment:
The test is still failling:
http://buildbot.python.org/all/builders/AMD64 OpenIndiana
2.7/builds/1670/steps/test/logs/stdio
==
ERROR: test_extract_unicode_filenames
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
koobs added the comment:
heads-up: Tests are still failing on FreeBSD (gcc clang) buildbots:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%20dtrace%202.7/builds/472/steps/test/logs/stdio
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Python-bugs-list
Christian Heimes added the comment:
it seems like file() can't handle unicode file names on FreeBSD. The FS
encoding is 'US-ASCII' on Snakebite's FreeBSD box.
/home/cpython/users/christian.heimes/2.7/Lib/zipfile.py(1078)_extract_member()
- with self.open(member, pwd=pwd) as source, \
(Pdb)
Serhiy Storchaka added the comment:
Here is a patch which skips test_extract_unicode_filenames if no Unicode
filesystem semantics on this platform.
--
Added file:
http://bugs.python.org/file29952/test_extract_unicode_filenames_skip.patch
___
Python
STINNER Victor added the comment:
I guess that test_extract_unicode_filenames_skip.patch will not fix the
failing test. The test fails because u\xf6.txt cannot be encoded to
sys.getfilesystemencoding() (which is ASCII on the FreeBSD buildbot). You
should test u\xf6.txt. You should move the
Roundup Robot added the comment:
New changeset d02507c9f973 by Serhiy Storchaka in branch '2.7':
Issue #17656: Fix extraction of zip files with unicode member paths.
http://hg.python.org/cpython/rev/d02507c9f973
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Terry J. Reedy added the comment:
A week's notice to push any almost ready IDLE bugfixes before the .rc's would
be nice. (I am assuming there are some, but would have to ask Roger.)
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
Yes; I won't have time for a few days, though.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Georg Brandl added the comment:
I guess I will join with 3.2 and 3.3 for #17666.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Ned Deily added the comment:
Perhaps we should hold off for a week or two to see if any other critical
problems show up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Georg Brandl added the comment:
Yes, although the new releases will get the standard rc period anyway.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
Changes by Gregory P. Smith g...@krypto.org:
--
priority: high - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Antoine Pitrou added the comment:
Perhaps this would deserve a 2.7.5?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
Serhiy Storchaka added the comment:
Yes, it's my fault. Here is a patch (with test) which fixes this regression in
2.7. This is 2.7 only issue, in Python 3 arcnames always are unicode. Please
test on Windows.
--
components: +Library (Lib)
keywords: +patch
priority: normal - high
Vhati added the comment:
The 2013-04-08 patch worked on Windows XP.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17656
___
___
New submission from Vhati:
Python 2.7.4 fails while extracting zip files when 'member' is a unicode path.
---
Traceback (most recent call last):
...
my_zip.extract(item, tmp_folder_path)
File D:\Apps\Python274\lib\zipfile.py, line 1024, in extract
return self._extract_member(member,
Vhati added the comment:
Apparently namelist() can return either ascii or unicode strings for its
members, depending on the archive. Obviously this'd apply to literal unicode
strings as well.
--
___
Python tracker rep...@bugs.python.org
Vhati added the comment:
Oops, passing a unicode literal to extract()'s member arg wouldn't be
sufficient.
The extract() method quietly converts strings to ZipInfo objects via
getinfo(member_string). Then _extract_member() takes the filename attribute of
that ZipInfo object, which causes
Martin v. Löwis added the comment:
It appears that this is a consequence of the changes in issue 6972, in
particular change 4d1948689ee1.
--
nosy: +Arfrever, amaury.forgeotdarc, benjamin.peterson, catalin.iacob,
georg.brandl, gregory.p.smith, larry, loewis, ned.deily, python-dev,
Changes by Gregory P. Smith g...@krypto.org:
--
title: Python 2.7.4 Breaks ZipFile Extraction - Python 2.7.4 breaks ZipFile
extraction of zip files with unicode member paths
versions: +Python 3.2, Python 3.3, Python 3.4
___
Python tracker
34 matches
Mail list logo
