[issue17671] io.BufferedRWPair can use uninitialized members

2014-02-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Stephen for your patch. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue17671] io.BufferedRWPair can use uninitialized members

2014-02-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 712b4665955d by Serhiy Storchaka in branch '2.7': Issue #17671: Fixed a crash when use non-initialized io.BufferedRWPair. http://hg.python.org/cpython/rev/712b4665955d New changeset 25ff4625680d by Serhiy Storchaka in branch '3.3': Issue #17671: Fix

[issue17671] io.BufferedRWPair can use uninitialized members

2014-02-10 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list ma

[issue17671] io.BufferedRWPair can use uninitialized members

2014-01-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Python implementation raises AttributeError, C implementations of other streams raise ValueError on uninitialized read/write. Therefore I think ValueError is more appropriate for BufferedRWPair too. Revised patch changes exception type and message to confor

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: About the test: +self.assertRaises(Exception, pair.read) +self.assertRaises(Exception, pair.write) First, you should check for the actual RuntimeError. Second, you need to pass the right arguments for these method calls: for example read(1) and

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Stephen Tu
Stephen Tu added the comment: patch with test in test_io -- Added file: http://bugs.python.org/file29835/bufferedio.withtest.patch ___ Python tracker ___

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch, Stephen. Could you add a test in Lib/test/test_io.py? -- ___ Python tracker ___ __

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Stephen Tu
Stephen Tu added the comment: _forward_call() now checks if reader/write is NULL- if so, throws a runtime exception -- keywords: +patch nosy: +Stephen.Tu Added file: http://bugs.python.org/file29814/bufferedio.patch ___ Python tracker

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-09 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-08 Thread Amaury Forgeot d'Arc
New submission from Amaury Forgeot d'Arc: This segfaults on all Python versions: io.BufferedRWPair.__new__(io.BufferedRWPair).read() The various "_forward_call" methods should check that the reader and writer objects are correctly initialized. Not NULL, at the very least. -- componen