Roundup Robot added the comment:
New changeset d62f71bd2192 by Brian Curtin in branch '3.3':
Add Nick Sloan for his contribution to #17732
http://hg.python.org/cpython/rev/d62f71bd2192
--
___
Python tracker rep...@bugs.python.org
Georg Brandl added the comment:
Thanks for the attribution, that was definitely an oversight on my part.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
Roundup Robot added the comment:
New changeset 6c5a3d194a10 by Georg Brandl in branch '3.3':
Closes issue #17732: ignore install-directory specific options in
http://hg.python.org/cpython/rev/6c5a3d194a10
--
nosy: +python-dev
___
Python tracker
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
Éric Araujo added the comment:
No, patch is good to go, I just need to find some time to commit it. If
another core dev wants to do it sooner, please feel free to do so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
Nick Sloan added the comment:
Just checking to see if anything else is needed from me on this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
Changes by Ilya Konkov eru...@gmail.com:
--
nosy: +eruart
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
___
Python-bugs-list mailing
Nick Sloan added the comment:
Éric,
Fixed the mention of packages, and made a frozenset of ignore_options. Think
this thing is ready to go. I have tested it, and it does the trick. Thanks for
helping me get this patch merged in.
--
Added file:
Nick Sloan added the comment:
Responded to comments with an updated patch. Thanks for all the feedback, and
sorry for the silly mistakes. Should have read up more thoroughly on the docs
style guide and the terminology. Hopefully the latest patch is ready to go (or
at least, nearly so).
Nick Sloan added the comment:
Here is another update. It has come to my attention that I missed some options:
prefix, exec-prefix, home, user and root
These have been added, and the docs and test have been updated to reflect the
change.
--
Added file:
Éric Araujo added the comment:
Looks good, thanks! I assume you also tested it manually?
I’ll take care of this for the next release.
--
nosy: +georg.brandl, larry
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
Nick Sloan added the comment:
Any feedback on this latest patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
___
Python-bugs-list
Éric Araujo added the comment:
Thanks for the patch, I left comments on rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
___
Nick Sloan added the comment:
Here is an updated patch with documentation changes and a new test. 5 tests in
distutils have errors. I have left those alone for now.
--
Added file: http://bugs.python.org/file29888/distutilsvenv.patch
___
Python
Nick Sloan added the comment:
That is, errors that pre-existed my patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17732
___
___
Nick Sloan added the comment:
Whoops. One of the options I had in my list doesn't actually exist. Here is yet
another update.
--
Added file: http://bugs.python.org/file29889/distutilsvenv.patch
___
Python tracker rep...@bugs.python.org
Vinay Sajip added the comment:
This looks to me as if it will need a patch in distutils. Unlike virtualenv,
which contains a patched copy of distutils (and hence allows having a .cfg
adjacent to it), pyvenv does not create patched modules in the venv. It does
not make sense to change this
Nick Sloan added the comment:
That's along the lines of what I've been thinking as I dig into this. I'd love
to take a stab at a patch for this if no one else has done so already.
--
___
Python tracker rep...@bugs.python.org
Nick Sloan added the comment:
Here is a patch that seems to fix the problem. It simply short-circuits
distutils options that change directories. This is my first python patch ever,
so I'm eager for comments. Is this the right approach?
--
keywords: +patch
Added file:
Nick Sloan added the comment:
On second thought, there is probably no good reason to ignore the build-*
settings. Here is an updated patch.
--
Added file: http://bugs.python.org/file29873/distutilsvenv.patch
___
Python tracker rep...@bugs.python.org
Vinay Sajip added the comment:
On second thought, there is probably no good reason to ignore the build-*
settings.
I was just about to mention this. I'm not an expert on distutils internals and
whether this is the best way to accomplish what's needed, but the approach
seems reasonable to
Nick Sloan added the comment:
My thought was that perhaps there will be other circumstances where we may want
to ignore options in the future. The idea was that by providing an
ignore_options list that can be extended, multiple conditions with different
sets of options can be stacked together
Éric Araujo added the comment:
I would ignore options from all config files, and do the simplest thing (i.e.
not add the ignore_options attribute).
--
assignee: vinay.sajip - eric.araujo
components: +Distutils -Library (Lib)
___
Python tracker
New submission from Nick Sloan:
When distutils.cfg defines an install-lib, it will be used within virtual
environments created using venv as well, which makes it impossible to install
things with setup.py or similar.
Steps to reproduce:
Create a distutils.cfg file and set a value for
Éric Araujo added the comment:
There is a --no-user-cfg option to disable reading ~/.pydistutils.cfg, but I
don’t recall an option to ignore the global config. How does virtualenv avoid
this problem, if it does?
--
assignee: eric.araujo - vinay.sajip
components: +Library (Lib)
Nick Sloan added the comment:
It looks like virtualenv includes an empty distutils.cfg at
myvirtualenv/lib/python3.3/distutils/distutils.cfg. Most of
myvirtualenv/lib/python3.3 is just symlinked to the base python version, but
myvirtualenv/lib/python3.3/distutils/ is not, and I bet this is
26 matches
Mail list logo
