[issue17738] Unnecessary "if" in SHA1_copy

2013-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset aec657f11b66 by Benjamin Peterson in branch '3.3': remove pointless code (closes #17738) http://hg.python.org/cpython/rev/aec657f11b66 -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rejected status: open -> close

[issue17738] Unnecessary "if" in SHA1_copy

2013-04-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +gregory.p.smith stage: -> patch review versions: +Python 2.7 -Python 3.1, Python 3.2, Python 3.5 ___ Python tracker ___ ___

[issue17738] Unnecessary "if" in SHA1_copy

2013-04-15 Thread Jonas Wagner
New submission from Jonas Wagner: I'm puzzled by the following code in SHA1_copy (at python/Modules/sha1module.c:320 if (Py_TYPE(self) == &SHA1type) { if ( (newobj = newSHA1object())==NULL) return NULL; } else { if ( (newobj = newSHA1object())==NULL)