[issue1775025] zipfile: Allow reading duplicate filenames

2008-05-19 Thread Scott Dial
Scott Dial <[EMAIL PROTECTED]> added the comment: In the patch you commented "why is 'filepos' computed next? It's never referenced." The answer is that back at r54152 (#1121142) the method was rewrote removing any reference to 'filepos', but the patch author failed to remove that line. Please re

[issue1775025] zipfile: Allow reading duplicate filenames

2008-05-19 Thread Benjamin Peterson
Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- type: -> feature request versions: +Python 2.6 _ Tracker <[EMAIL PROTECTED]> _

[issue1775025] zipfile: Allow reading duplicate filenames

2008-05-19 Thread Graham Horler
Graham Horler <[EMAIL PROTECTED]> added the comment: Updated to latest revision, and converted documentation part of the patch to reST. Removed the line that pointlessly computes 'filepos', as requested by Scott Dial. (Please excuse my reST, I'm new to it and it's getting late). Added file:

[issue1775025] zipfile: Allow reading duplicate filenames

2008-05-20 Thread Georg Brandl
Georg Brandl <[EMAIL PROTECTED]> added the comment: Thanks, reviewed, added tests and committed as r63499. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed _ Tracker <[EMAIL PROTECTED]> _