[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 32a5de0e91d5 by Vinay Sajip in branch '2.7': Issue #17795: Reverted backwards-incompatible change in SysLogHandler with Unix domain sockets. http://hg.python.org/cpython/rev/32a5de0e91d5 New changeset d03784713786 by Vinay Sajip in branch '3.3':

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-21 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: Added file: http://bugs.python.org/file29970/cd970801b061.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17795 ___

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-21 Thread Vinay Sajip
Vinay Sajip added the comment: Okay, I made the change to default socktype=None. Please try out the latest patch (ideally on all Python versions you can test with) to confirm it's OK. Then I can apply to 2.7/3.2/3.3/default. Thanks. -- ___ Python

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-21 Thread Mike Lundy
Mike Lundy added the comment: I've tested in our full dev setup, and it seems to work fine; I've also tested on my laptop, no problems there either. Unfortunately, that's python 2.7.4 in both cases. I don't really have a python3 setup I can bump up to test. --

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- hgrepos: +183 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17795 ___ ___ Python-bugs-list

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: Added file: http://bugs.python.org/file29950/6e46f4e08717.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17795 ___

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Vinay Sajip
Vinay Sajip added the comment: I've attached an alternative patch. The default socktype stays as socket.SOCK_DGRAM, but you can specify socktype=None to get the SOCK_DGRAM falling back to SOCK_STREAM behaviour. Can you confirm that this alternative approach works in your environment? (This

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Mike Lundy
Mike Lundy added the comment: It doesn't fix it unless I change the configuration (and in some cases the code) for every SyslogHandler across all of our projects, plus every single library we use. Google around For SysLogHandler /dev/log socktype and then compare with SysLogHandler /dev/log.

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Vinay Sajip
Vinay Sajip added the comment: Does that mean that if I just change the default back to socktype=None, that will be good enough? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17795 ___

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Mike Lundy
Mike Lundy added the comment: On top of your patch? Yeah, I think so. (I wrote it the way I did so it could handle syslog configuration changes, but that's kind of an uncommon case). Thanks! -- ___ Python tracker rep...@bugs.python.org

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-19 Thread Mike Lundy
New submission from Mike Lundy: The changed merged from http://bugs.python.org/issue16168 causes a regression in SysLogHandler behavior. The socktype of /dev/log is dependent on syslog configuration, and the fallback behavior (trying SOCK_DGRAM and then SOCK_STREAM if the former failed) was

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-19 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- assignee: - vinay.sajip nosy: +vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17795 ___