[issue17851] Grammar errors in threading.Lock documentation

Changes by Ezio Melotti : -- stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue17851] Grammar errors in threading.Lock documentation

Ramchandra Apte added the comment: I'm saying that they aren't valid grammar mistakes (there is no grammar mistake). I agree with Georg Brandl's comment. On 27 April 2013 20:18, Andriy Mysyk wrote: > > Andriy Mysyk added the comment: > > Ramachandra, if I understand you correctly, I think what

[issue17851] Grammar errors in threading.Lock documentation

R. David Murray added the comment: I (as a native English speaker, FWIW) agree that the existing text is correct insofar as the reported problems go. I, however, would remove the comma after 'block'. I don't know that it is wrong as written, but it reads strangely to my ear. -- nosy

[issue17851] Grammar errors in threading.Lock documentation

Georg Brandl added the comment: I see no problem with both points: "block" is the correct verb form in this context ("attempts" being plural), and the version including comma reads better to me. -- nosy: +georg.brandl resolution: -> works for me status: open -> closed ___

[issue17851] Grammar errors in threading.Lock documentation

Andriy Mysyk added the comment: Ramachandra, if I understand you correctly, I think what you are saying that both are grammar mistakes and the first one could addressed by adding "s" to block. -- ___ Python tracker

[issue17851] Grammar errors in threading.Lock documentation

Ramchandra Apte added the comment: oops, should be "the crowd blocks me" -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue17851] Grammar errors in threading.Lock documentation

Ramchandra Apte added the comment: afaik they don't seem to be grammatical errors "subsequent attempts to acquire it block" - block is the verb, don't see anything wrong similar example: the crowd blocks me. (present tense) "which one of the waiting threads proceeds is not defined, and may vary

[issue17851] Grammar errors in threading.Lock documentation

Andriy Mysyk added the comment: submitting a patch for both grammar errors -- assignee: -> docs@python components: +Documentation keywords: +patch nosy: +docs@python Added file: http://bugs.python.org/file30029/issue17851.patch ___ Python tracker

[issue17851] Grammar errors in threading.Lock documentation

New submission from Andriy Mysyk: No need for comma in "which one of the waiting threads proceeds is not defined, and may vary across implementations." "Once a thread has acquired a lock, subsequent attempts to acquire it block, until it is released; any thread may release it" should read "are