[issue17896] Move Windows external libs from \..\ to \externals

Roundup Robot added the comment: New changeset 7d22dbf3a0dc by Martin v. Löwis in branch '3.4': Issue #17896: Update msi.py to new externals dir. https://hg.python.org/cpython/rev/7d22dbf3a0dc -- ___ Python tracker

[issue17896] Move Windows external libs from \..\ to \externals

Martin v. Löwis added the comment: I noticed this issue today when trying to make the 3.4.3rc1 build; this broke Tools/msi.py, which fails to find the license files and the tcltk files. -- ___ Python tracker _

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: Good point, David. Jeremy, Trent, you're the only other Windows buildbot operators as far as I know; feel free to clean up the old externals locations as you like. Also, sorry to make it a bit hairier to operate, but I think this is a big enough improvement fo

[issue17896] Move Windows external libs from \..\ to \externals

David Bolen added the comment: I noticed this issue when checking on some recent 2.7 branch failures on my buildbot. It might be worth noting this change to any Windows buildbot owners since we all have existing trees now with a lot of stranded external folders that can be removed. For what

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: Thanks for the test, Terry. Committed. -- assignee: -> zach.ware resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker __

[issue17896] Move Windows external libs from \..\ to \externals

Roundup Robot added the comment: New changeset 62ce0f623154 by Zachary Ware in branch '2.7': Issue #17896: Move Windows external lib sources from .. to externals. https://hg.python.org/cpython/rev/62ce0f623154 New changeset b5e9bc4352e1 by Zachary Ware in branch '3.4': Issue #17896: Move Windows

[issue17896] Move Windows external libs from \..\ to \externals

Terry J. Reedy added the comment: The patch looks pretty straightforward. Running the revised external.bat and then pcbuild.sln seem to give the same result as before. So this looks ready to me. As to Steve's merge question: since externals is ignored and not part of the python.org reposito

[issue17896] Move Windows external libs from \..\ to \externals

Terry J. Reedy added the comment: After seeing your new diagram and glancing at the patch, we are pretty much in agreement. I would like to see this change so I can delete the extra layer of directories. I will try to do a review and test tomorrow. I will also check the devguide to see if I

[issue17896] Move Windows external libs from \..\ to \externals

Changes by Zachary Ware : Added file: http://bugs.python.org/file37059/issue17896-3.4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: I don't think we're on the same page here, Terry, so here's some patches and a wall of text to hopefully make me clearer. In particular, I don't understand what you mean by "merge multiple tcltk directories in isolated build directories", as the "merge" and "iso

[issue17896] Move Windows external libs from \..\ to \externals

Changes by Zachary Ware : Removed file: http://bugs.python.org/file30113/move_externals.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue17896] Move Windows external libs from \..\ to \externals

Changes by Zachary Ware : Added file: http://bugs.python.org/file37060/issue17896-2.7.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17896] Move Windows external libs from \..\ to \externals

Terry J. Reedy added the comment: I could not find an issue specifically for the tcltk problem. I just explained the problem as I know it in msg230120 of #17896. Some sort of fix is required before we can merge multiple tcltk directories in isolated build directories of the sort you diagramm

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: There's no change from the status quo on that front: the only change is that the $(externalsDir) VS variable becomes "..\externals" instead of "..\..". Is there an open issue for versioning the tcltk[64] dirs? -- ___ P

[issue17896] Move Windows external libs from \..\ to \externals

Terry J. Reedy added the comment: Since all other dependency directories are dependency version specific, the only problem with a common external directory is the unversioned tcltk/. What do you plan to do with that? -- ___ Python tracker

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: Basically, after: hg clone h.p.o/cpython default hg share default 3.4 hg share default 2.7 hg -R 3.4 update 3.4 hg -R 2.7 update 2.7 the 2.7, 3.4, and default directories are separate working copies created from the same history, each at a different revision. A

[issue17896] Move Windows external libs from \..\ to \externals

Steve Dower added the comment: Sounds good to me. I thought about the shared repo approach, but I don't understand fully how merging between 2.7, 3.4 and default works in that scenario (simply because I've never tried it - maybe it's really easy?) -- __

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: I'm ambivalent on per-version externals dirs by now; I've since found it much easier to maintain hg-shared repos per branch. I'll go ahead with this shortly on all three branches, unless there are objections to it on 2.7 and 3.4. -- versions: +Python 2.

[issue17896] Move Windows external libs from \..\ to \externals

Steve Dower added the comment: Not so keen on having separate folders for Python version, mostly because I want to avoid having the current version in too many locations. I've settled on patchlevel.h as the canonical source of the version number for my VC14 branch - everything else should read

[issue17896] Move Windows external libs from \..\ to \externals

Mark Lawrence added the comment: I see that this has also been raised on #22262. As nobody has objected can't we just get on with it? -- ___ Python tracker ___

[issue17896] Move Windows external libs from \..\ to \externals

Zachary Ware added the comment: After the most recent changes to the buildbot scripts, it would be every time without a patch to the clean script, but at the time I only meant a single time (which really isn't a big deal). The patch is well out of date, I can update it if we can come to a cons

[issue17896] Move Windows external libs from \..\ to \externals

Mark Lawrence added the comment: I also find the location annoying and would be happy to see it moved. Regarding the "extra long build time on the buildbots due to having to recompile Tcl/Tk and OpenSSL" is this a one off the first time you run after the commit, or does it always happen becaus

[issue17896] Move Windows external libs from \..\ to \externals

Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue17896] Move Windows external libs from \..\ to \externals

Changes by Antoine Pitrou : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17896] Move Windows external libs from \..\ to \externals

New submission from Zachary Ware: PCbuild\readme.txt has a comment from Trent Nelson dated 2-April-2008 suggesting moving the external library location for Windows from "\..\" to "\external\" to make switching between versions easier. I've gotten rather annoyed with having all of the external