[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Alexandre. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset d565310e7ae3 by Serhiy Storchaka in branch 'default': Issue #17897: Optimized unpickle prefetching. http://hg.python.org/cpython/rev/d565310e7ae3 -- nosy: +python-dev ___ Python tracker

[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: Looks good to me! Feel free to commit. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Microbenchmark: $ ./python -c "import pickle; d = b'x' * 10**6; f = open('test.pickle3', 'wb'); pickle.dump(d, f, 3); f.close()" $ ./python -m timeit -s "from pickle import load" "with open('test.pickle3', 'rb') as f: load(f)" Unpatched: 100 loops, best o

[issue17897] Optimize unpickle prefetching

2013-11-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch is synchronized with tip (it was desynchronized since 23459df0753e). -- Added file: http://bugs.python.org/file32913/pickle_peek_2.patch ___ Python tracker

[issue17897] Optimize unpickle prefetching

2013-07-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This patch is orthogonal to the PEP 3154 framing. The affecting of issue18073 is only an unexpected side effect. -- ___ Python tracker ___ __

[issue17897] Optimize unpickle prefetching

2013-07-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'd prefer to see efforts go towards finishing the PEP 3154 implementation... -- ___ Python tracker ___

[issue17897] Optimize unpickle prefetching

2013-07-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17897] Optimize unpickle prefetching

2013-07-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See issue18073 for test case. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue17897] Optimize unpickle prefetching

2013-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No, I have no any interesting results. ;) If an effect exists, it should reveal itself only in rare cases and be very small. This patch may be considered rather as a tiny refactoring (it decreases a number of code lines). --

[issue17897] Optimize unpickle prefetching

2013-05-03 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17897] Optimize unpickle prefetching

2013-05-03 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: Do you have benchmark results to show the code with the patch is faster? -- ___ Python tracker ___ ___

[issue17897] Optimize unpickle prefetching

2013-05-03 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: When C implementation of the unpickle reads a data, it also prefetches some data using peek() (if available) and then concatenates read and peeked chunks in the one input buffer. This causes an additional copying when a large data is read. The proposed pat