[issue17900] Recursive OrderedDict pickling

2016-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Reported PyYAML issue: https://bitbucket.org/xi/pyyaml/issues/61/ordereddict-doesnt-round-trip. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue17900] Recursive OrderedDict pickling

2016-06-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: At this point, we can drop it. PyYAML will just have to deal with it. -- assignee: rhettinger -> ___ Python tracker

[issue17900] Recursive OrderedDict pickling

2016-06-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think it is too late to revert this change. Is it worth to add a workaround for PyYAML if it still hasn't fixed serialization of OrderedDicts? -- ___ Python tracker

[issue17900] Recursive OrderedDict pickling

2015-07-21 Thread Ethan Furman
Changes by Ethan Furman et...@stoneleaf.us: -- nosy: -ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___ ___ Python-bugs-list

[issue17900] Recursive OrderedDict pickling

2014-11-07 Thread Ethan Furman
Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___ ___ Python-bugs-list

[issue17900] Recursive OrderedDict pickling

2014-11-02 Thread Raymond Hettinger
Raymond Hettinger added the comment: This patch caused a regression by breaking designed-in support for pickling using PyYAML (note, there was a test for yaml support, but this patch defeated the test). As a result of the patch, ordering now gets lost during a dump/load roundtrip. This

[issue17900] Recursive OrderedDict pickling

2014-11-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Can you explain what is broken independently of PyYAML? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___

[issue17900] Recursive OrderedDict pickling

2014-11-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, sorry, I did not notice test_yaml_linkage. And in any case this test was broken (should be rv[1][0] instead of rv[1]). I don't like to revert these changes, and the reversion can break a code written for 3.4 which pickles recursive OrderedDicts. I

[issue17900] Recursive OrderedDict pickling

2014-11-02 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: serhiy.storchaka - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___

[issue17900] Recursive OrderedDict pickling

2013-05-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 56f25569ba86 by Serhiy Storchaka in branch 'default': Issue #17900: Allowed pickling of recursive OrderedDicts. Decreased pickled http://hg.python.org/cpython/rev/56f25569ba86 -- nosy: +python-dev ___

[issue17900] Recursive OrderedDict pickling

2013-05-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900

[issue17900] Recursive OrderedDict pickling

2013-05-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___ ___ Python-bugs-list mailing list

[issue17900] Recursive OrderedDict pickling

2013-05-20 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: The patch looks good to me. So go ahead and submit it. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___

[issue17900] Recursive OrderedDict pickling

2013-05-20 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17900 ___ ___

[issue17900] Recursive OrderedDict pickling

2013-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In additional the patch decreases the size of the pickled data, speeds up pickling and unpickling. $ ./python -c import collections, pickle; od = collections.OrderedDict((i, i) for i in range(10)); print(len(pickle.dumps(od))) Without patch: 1536827.

[issue17900] Recursive OrderedDict pickling

2013-05-03 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Here is a patch which allows pickling of recursive OrderedDicts. Actually it simplifies __reduce__() code. -- components: Library (Lib) files: OrderedDict_pickle_recursive.patch keywords: patch messages: 188325 nosy: alexandre.vassalotti, pitrou,