Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
Roundup Robot added the comment:
New changeset e430973149ed by Serhiy Storchaka in branch '2.7':
Issue #17923: glob() patterns ending with a slash no longer match non-dirs on
http://hg.python.org/cpython/rev/e430973149ed
New changeset 5033589a752d by Serhiy Storchaka in branch '3.4':
Issue
Serhiy Storchaka added the comment:
Thank you Delhallt.
Mark, yes, you are right, but the code can be simplified even more, to do less
syscalls.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker
David Edelsohn added the comment:
3.4 and default also. The failure occurs on all branches and default.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
___
David Edelsohn added the comment:
I tried the patch with Python-2.7.8 and it fixes the test_glob failure. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
David Edelsohn added the comment:
The failure also occurs with Python 3 and the patch fixes test_glob for those
releases.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
koobs added the comment:
David, reproducible on 3.4 and default?
We can use Version to reflect where changes need to be committed
--
nosy: +koobs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
Ezio Melotti added the comment:
Someone on AIX should verify this patch and confirm that it fixes the issue
(and if Python 3 is affected or not).
--
keywords: +easy
title: test glob with trailing slash fail - test glob with trailing slash fail
on AIX 6.1
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +David.Edelsohn
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
___
Mark Lawrence added the comment:
Couldn't part of the patch be simplified to:-
if basename or os.path.isdir(dirname):
yield pathname
or have I misread it?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
components: +Library (Lib)
nosy: +ezio.melotti
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17923
___
New submission from Delhallt:
test_glob's trailing_slash tests fails on AIX 6.1/Python 2.7.4:
The code section for no_magic/slash case seems to be the issue.
Attached patch resolves issue.
FAIL: test_glob_directory_with_trailing_slash (test.test_glob.GlobTests)
13 matches
Mail list logo