[issue17989] ElementTree.Element broken attribute setting

Changes by Eli Bendersky : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Py

[issue17989] ElementTree.Element broken attribute setting

Roundup Robot added the comment: New changeset 65680e3a7f07 by Eli Bendersky in branch '3.3': Issue #17989: fix typo in error message http://hg.python.org/cpython/rev/65680e3a7f07 New changeset 19767536ce84 by Eli Bendersky in branch 'default': Issue #17989: fix typo in error message http://hg.p

[issue17989] ElementTree.Element broken attribute setting

Changes by Arfrever Frehtes Taifersar Arahesis : -- resolution: fixed -> stage: committed/rejected -> status: closed -> open ___ Python tracker ___

[issue17989] ElementTree.Element broken attribute setting

Joe Stuart added the comment: Looks like a typo in arbitrary. AttributeError: Can't set arbitraty attributes on Element -- ___ Python tracker ___ ___

[issue17989] ElementTree.Element broken attribute setting

Changes by Eli Bendersky : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue17989] ElementTree.Element broken attribute setting

Eli Bendersky added the comment: Fixed. Thanks for the report! Python 3.4.0a0 (default:1b760f926846+9682241dc8fc+, May 18 2013, 07:52:49) [GCC 4.6.3] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import xml.etree.ElementTree as ET; j = ET.Element('j') >>> j

[issue17989] ElementTree.Element broken attribute setting

Roundup Robot added the comment: New changeset 9682241dc8fc by Eli Bendersky in branch '3.3': Issue #17989: element_setattro returned incorrect error value. http://hg.python.org/cpython/rev/9682241dc8fc New changeset b111ae4f83ef by Eli Bendersky in branch 'default': Issue #17989: element_setatt

[issue17989] ElementTree.Element broken attribute setting

Changes by Eli Bendersky : -- stage: -> needs patch type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue17989] ElementTree.Element broken attribute setting

Eli Bendersky added the comment: The problem is that element_setattro is returning a wrong value for error - NULL instead of -1. So the exception is set and is triggered on the next line instead. Will fix for 3.3 and default branches -- ___ Python t

[issue17989] ElementTree.Element broken attribute setting

Eli Bendersky added the comment: Yes, overwriting the Python classes with C classes is not an error, but the original issue is legit. The error should be more immediately reported. -- ___ Python tracker __

[issue17989] ElementTree.Element broken attribute setting

Changes by Eli Bendersky : -- assignee: -> eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue17989] ElementTree.Element broken attribute setting

Changes by Arfrever Frehtes Taifersar Arahesis : Removed file: http://bugs.python.org/file30301/ElementTree.patch ___ Python tracker ___ ___ P

[issue17989] ElementTree.Element broken attribute setting

Arfrever Frehtes Taifersar Arahesis added the comment: Replacement of pure-Python classes by C-accelerated classes is intentional. http://docs.python.org/3.3/library/xml.etree.elementtree.html "Changed in version 3.3: This module will use a fast implementation whenever available. The xml.etree.

[issue17989] ElementTree.Element broken attribute setting

Joe Stuart added the comment: Forgot to update the XMLParser() assignment. -- Added file: http://bugs.python.org/file30301/ElementTree.patch ___ Python tracker ___ __

[issue17989] ElementTree.Element broken attribute setting

Changes by Joe Stuart : Removed file: http://bugs.python.org/file30300/ElementTree.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17989] ElementTree.Element broken attribute setting

Joe Stuart added the comment: This patch should fix the issue of the classes being overwritten by the c accelerated ones. -- Added file: http://bugs.python.org/file30300/ElementTree.patch ___ Python tracker __

[issue17989] ElementTree.Element broken attribute setting

Changes by Joe Stuart : Removed file: http://bugs.python.org/file30298/ElementTree.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17989] ElementTree.Element broken attribute setting

Joe Stuart added the comment: At the end of ElementTree all of the c accelerators are being imported and it looks like only XMLParser is being used. Here is a patch that only imports XMLParser. -- keywords: +patch Added file: http://bugs.python.org/file30298/ElementTree.patch

[issue17989] ElementTree.Element broken attribute setting

Joe Stuart added the comment: It looks like it's being called from the c extension. I would think it should still throw an exception though? >>> e = etree.Element >>> e.ham = 1 Traceback (most recent call last): File "", line 1, in TypeError: can't set attributes of built-in/extension type

[issue17989] ElementTree.Element broken attribute setting

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list

[issue17989] ElementTree.Element broken attribute setting

Changes by Antoine Pitrou : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17989] ElementTree.Element broken attribute setting

New submission from Jakub Wilk: Setting attributes on ElementTree.Element objects is broken: it succeeds without exception, but then the following statement fails with AttributeError (unless that statement sets an Element's attribute too): $ python3.3 test-element-setattr.py Hello world!Trace