Roundup Robot added the comment:
New changeset 9565b56a4615 by Victor Stinner in branch '2.7':
Issue #18028: Fix aliasing issue in READ_TIMESTAMP() of ceval.c on x86_64,
https://hg.python.org/cpython/rev/9565b56a4615
New changeset adb445578995 by Victor Stinner in branch '3.4':
Issue #18028:
STINNER Victor added the comment:
3 core developers reviewed Christian's patch, so it also looks good to me :-)
Since Christian looks to be busy, I commited his patch. Thanks Christian for
your fix.
We might enable -fstrict-aliasing later, at least to compile Python core (not
to build
Serhiy Storchaka added the comment:
LGTM.
--
assignee: - christian.heimes
nosy: +serhiy.storchaka
stage: patch review - commit review
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18028
Antoine Pitrou added the comment:
Looks good to me as well.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18028
___
___
Raymond Hettinger added the comment:
+1
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18028
___
___
Python-bugs-list mailing
Christian Heimes added the comment:
The warning is caused by the X86_64 code for timestamps:
#define READ_TIMESTAMP(val) \
__asm__ __volatile__(rdtsc : \
=a (((int*)(val))[0]), =d (((int*)(val))[1]));
The patch fixes the issue with two temp vars.
--
New submission from Bohuslav Slavek Kabrda:
Hi,
I'm getting these warnings with -fstrict-aliasing, compiling Python 3.3.2
(compiling with gcc 4.4.7):
/builddir/build/BUILD/Python-3.3.2/Python/ceval.c: In function
'PyEval_EvalFrameEx':
/builddir/build/BUILD/Python-3.3.2/Python/ceval.c:1006:
Arfrever Frehtes Taifersar Arahesis added the comment:
Your Python/ceval.c has custom patches applied. Line 1006 is a comment in
unmodified Python/ceval.c in Python 3.3.2. This bug might be caused by your
patches.
Alternatively it is a bug in GCC 4.4.7.
I get 0 warnings for unmodified
Bohuslav Slavek Kabrda added the comment:
Hmm, you're probably right. The problem seems to be in downstream redefinition
of READ_TIMESTAMP. Sorry for the fuzz, closing.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
Bohuslav Slavek Kabrda added the comment:
Actually, this appears on vanilla Python 3.3 with -DWITH_TSC:
Python/ceval.c: In function ‘PyEval_EvalFrameEx’:
Python/ceval.c:986:5: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
10 matches
Mail list logo