[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Change by Phil Connell : -- nosy: +pconnell ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

TK added the comment: Hi everybody, I just submitted a PR for this issue. It's my first contribution to the cPython project so please let me know if I need to change anything. -- ___ Python tracker

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Change by TK : -- pull_requests: +15461 pull_request: https://github.com/python/cpython/pull/15811 ___ Python tracker ___ ___

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Change by TK : -- nosy: +ta1hia ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Avinash Sajjanshetty added the comment: I was looking for an easy patch to submit. I can take an attempt at this? -- nosy: +avi ___ Python tracker ___

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Claudiu Popa added the comment: I got a failure on FreeBSD: [1/1] test_shutil test test_shutil failed -- Traceback (most recent call last): File /tank/libs/cpython/Lib/test/test_shutil.py, line 1258, in test_chown shutil.chown(os.path.basename(filename), dir_fd=dirfd) File

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Berker Peksag added the comment: Here's a patch. -- keywords: +patch nosy: +berker.peksag stage: needs patch - patch review Added file: http://bugs.python.org/file35633/issue18108.diff ___ Python tracker rep...@bugs.python.org

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Claudiu Popa added the comment: Looks good to me. But aren't the last two lines skipped if an error is raised by the first line from the with block? +with self.assertRaises(FileNotFoundError): +shutil.chown('invalid-file', user=uid, dir_fd=dirfd) +

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Claudiu Popa added the comment: Hi. Would you like to provide a patch? -- keywords: +easy nosy: +Claudiu.Popa stage: - needs patch type: - enhancement versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

New submission from Colin Watson: Python 3.3 added the dir_fd and follow_symlinks keyword arguments to os.chown; it also added the shutil.chown function. Unfortunately the latter, while useful, does not support these new keyword arguments. It would be helpful if it did. --

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

Changes by Hynek Schlawack h...@ox.cx: -- nosy: +hynek versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18108 ___