[issue18116] getpass.unix_getpass() always fallback to sys.stdin

Martin Panter added the comment: I opened Issue 21310 about a ResourceWarning from open() which I suspect is the same as what was originally described here. -- nosy: +vadmium ___ Python tracker ___

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

Roundup Robot added the comment: New changeset 100f632d4306 by R David Murray in branch '3.3': #18116: backport fix to 3.3 since real-world failure mode demonstrated. http://hg.python.org/cpython/rev/100f632d4306 New changeset 29a5a5b39dd6 by R David Murray in branch 'default': Mostly-null merge

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

R. David Murray added the comment: I played around with this for a bit, but I couldn't come up with any test improvements, or any way to test the bug that is being fixed. So I just committed it as is. Thanks, Serhiy. And thanks Vajrasky for giving it a try and figuring out some of the stuff

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

Roundup Robot added the comment: New changeset 70f55dc9d43f by R David Murray in branch 'default': #18116: getpass no longer always falls back to stdin. http://hg.python.org/cpython/rev/70f55dc9d43f -- nosy: +python-dev ___ Python tracker

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

R. David Murray added the comment: The test changes look correct to me, but it sure would be nice to come up with less fragile tests. For a function like this, though, it probably isn't possible. -- ___ Python tracker

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

Serhiy Storchaka added the comment: Here is a patch which fixes getpass bug: unix_getpass() always fallback to sys.stdin. As side effect it also fixes resource warning in getpass(). I'm not sure I have correctly changed tests. David, could you please review the patch? -- nosy: +gregor