[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: I give up on that close. I closed my PR 7827 and PR 7966. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by STINNER Victor : -- pull_requests: +7575 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by STINNER Victor : -- pull_requests: +7434 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: New changeset bc3df70b266304f78ebe5eabead71cabd4738d12 by Victor Stinner in branch '2.7': bpo-18174: Fix fd_count() on FreeBSD (GH-7420) https://github.com/python/cpython/commit/bc3df70b266304f78ebe5eabead71cabd4738d12 --

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by STINNER Victor : -- pull_requests: +7045 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: New changeset 64856ad8b7279718ff10a9fb32003c2221af7228 by Victor Stinner in branch '2.7': bpo-18174: regrtest -R 3:3 now also detects FD leak (#7409) https://github.com/python/cpython/commit/64856ad8b7279718ff10a9fb32003c2221af7228 --

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by STINNER Victor : -- pull_requests: +7035 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: New changeset 270581905cab2747ae8f7ee945301d6a29509cc7 by Victor Stinner in branch '2.7': bpo-18174: Fix file descriptor leaks in tests (GH-7408) https://github.com/python/cpython/commit/270581905cab2747ae8f7ee945301d6a29509cc7 --

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Change by STINNER Victor : -- pull_requests: +7034 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Changes by Ezio Melotti : -- stage: -> patch review type: -> enhancement ___ Python tracker ___

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset 72129c767c92 by Victor Stinner in branch 'default': Issue #18174: "python -m test --huntrleaks ..." now also checks for leak of https://hg.python.org/cpython/rev/72129c767c92 -- ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: I commited the first part to check for file descriptor leak. I didn't commit the second part, to check for Windows handle leak. -- ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset ec2ef7525fa5 by Victor Stinner in branch 'default': Issue #18174: Fix test_regrtest when Python is compiled in release mode https://hg.python.org/cpython/rev/ec2ef7525fa5 -- ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset 0e7d71a3bf0d by Victor Stinner in branch 'default': Issue #18174: Explain why is_valid_fd() uses dup() instead of fstat() https://hg.python.org/cpython/rev/0e7d71a3bf0d -- ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Charles-François Natali added the comment: Richard Oudkerk added the comment: I can't remember why I did not use fstat() -- probably it did not occur to me. I probably have Alzeihmer, I was sure I heard a reasonable case for dup() vs fstat(). The only thing I can think of is that fstat() can

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Antoine Pitrou added the comment: fstat() can do I/O, or can fail for other reasons. If you don't want to create a new fd, I think you can do dup2(fd, fd). I don't understand the reason for the following code: +def check_handle_deltas(deltas): +return abs(sum(deltas)) = min(3,

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: fstat() can do I/O, or can fail for other reasons. Oh, I forgot this reason. Maybe we should add a comment to explain that. I mean in the patch for this issue but also in is_valid_fd() (Python/pythonrun.c). -- ___

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Richard Oudkerk added the comment: I can't remember why I did not use fstat() -- probably it did not occur to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174 ___

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: Modified patch to use os.fstat(), and try to use /proc/self/fd/ on Linux. -- Added file: http://bugs.python.org/file36147/fdleak-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset 379aad232000 by Victor Stinner in branch '3.4': Issue #11453, #18174: Fix leak of file descriptor in test_asyncore http://hg.python.org/cpython/rev/379aad232000 New changeset 0ced2d2325fb by Victor Stinner in branch 'default': (Merge 3.4) Issue

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset 746339776f19 by Victor Stinner in branch '3.4': Issue #18174: Fix leak of file descriptor in test_tempfile http://hg.python.org/cpython/rev/746339776f19 New changeset 017d701116d5 by Victor Stinner in branch 'default': (Merge 3.4) Issue #18174: Fix

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Charles-François Natali added the comment: The patch looks good. I just think it would be nice to expose _fdcount() in test.support. -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: Why not using os.fstat() instead of os.dup() to check if a file descriptor is open or not? It's strange to create a new file descriptor with os.dup() to count the file descriptors. -- ___ Python tracker

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Charles-François Natali added the comment: Why not using os.fstat() instead of os.dup() to check if a file descriptor is open or not? I asked myself the same question, but IIRC, fstat() doesn't always work on Windows (of course). -- ___ Python

[issue18174] Make regrtest with --huntrleaks check for fd leaks

STINNER Victor added the comment: I asked myself the same question, but IIRC, fstat() doesn't always work on Windows (of course). Can you please elaborate? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Charles-François Natali added the comment: STINNER Victor added the comment: I asked myself the same question, but IIRC, fstat() doesn't always work on Windows (of course). Can you please elaborate? Not really, since I don't know much about Windows, but that's something I think I heard.

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Mark Lawrence added the comment: Just flagging this up as testing is rather important. -- components: +Tests nosy: +BreamoreBoy versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174 ___ ___

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Richard Oudkerk added the comment: Updated version which adds checks for handle leaks on Windows. -- Added file: http://bugs.python.org/file30561/fdleak.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174 ___ ___ Python-bugs-list

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Roundup Robot added the comment: New changeset a7381fe515e8 by Richard Oudkerk in branch '2.7': Issue #18174: Fix fd leaks in tests. http://hg.python.org/cpython/rev/a7381fe515e8 New changeset 46fe1bb0723c by Richard Oudkerk in branch '3.3': Issue #18174: Fix fd leaks in tests.

[issue18174] Make regrtest with --huntrleaks check for fd leaks

Richard Oudkerk added the comment: The test_shutil leak is caused by #17899. The others are fixed by a7381fe515e8 and 46fe1bb0723c. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18174

[issue18174] Make regrtest with --huntrleaks check for fd leaks

New submission from Richard Oudkerk: regrtest already tests for refcount leaks and memory allocation leaks. It can also be made to check for file descriptor leaks (and perhaps also handles on Windows). Running with the attached patch makes it look like test_openpty, test_shutil,