Berker Peksag added the comment:
Updated patch adressing Brett's comments.
--
Added file: http://bugs.python.org/file30585/issue18193_v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18193
Brett Cannon added the comment:
Answered Berker's questions from the review. At this point Berker just needs to
tweak one line in the test and it should then be good to go.
--
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
Added file: http://bugs.python.org/file30586/issue18193_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18193
___
Brett Cannon added the comment:
With Berker's nice use of TestCase.subTest() I think the patch is good to go! I
should hopefully get this checked in today or tomorrow.
--
resolution: - fixed
stage: patch review - commit review
status: open - pending
Brett Cannon added the comment:
Thanks for the patch, Berker!
--
assignee: - brett.cannon
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18193
Roundup Robot added the comment:
New changeset 01da7bf11ca1 by Brett Cannon in branch 'default':
Issue #18193: Add importlib.reload(), documenting (but not
http://hg.python.org/cpython/rev/01da7bf11ca1
--
nosy: +python-dev
status: pending - open
___
Berker Peksag added the comment:
Here's a patch. Changes:
- Used types.ModuleType instead of type(sys)
- Updated imp and importlib docs
- Moved test_imp.ReloadTests to test_importlib.test_api.ReloadTests
--
keywords: +patch
nosy: +berker.peksag
stage: test needed - patch review
Added
New submission from Brett Cannon:
For convenience it should live directly off of importlib and not importlib.util.
--
components: Library (Lib)
messages: 190982
nosy: brett.cannon
priority: normal
severity: normal
stage: test needed
status: open
title: Move imp.reload() to importlib
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18193
___
