[issue18294] zlib module is not completly 64-bit safe

Roundup Robot added the comment: New changeset 0cca6c5513d2 by Victor Stinner in branch 'default': Issue #18294: Fix uint_converter() in zlibmodule.c, fix the UINT_MAX check http://hg.python.org/cpython/rev/0cca6c5513d2 -- ___ Python tracker

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: LGTM. I changed the uint parser to raise a ValueError instead of an OverflowError, so the unit test doesn't need to be adapted. Thanks again Serhiy for your review :) I doesn't want to backport the fix to Python 2.7 or 3.3, it's more intrusive than what I

[issue18294] zlib module is not completly 64-bit safe

Roundup Robot added the comment: New changeset f947fe289db8 by Victor Stinner in branch 'default': Close #18294: Fix the zlib module to make it 64-bit safe http://hg.python.org/cpython/rev/f947fe289db8 -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: zlib_64bit-3.patch: updated patch which fixes also the PyArg_ParseTuple() convert for C int and C unsigned int. -- Added file: http://bugs.python.org/file32710/zlib_64bit-3.patch ___ Python tracker

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: zlib_64bit-4.patch: * fix usage of argument clinic, add a uint_converter * fix zlib_Decompress_decompress(): use an unsigned int, not an int (remove int_converter()) * fix two bugs and unit tests -- Added file:

[issue18294] zlib module is not completly 64-bit safe

Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18294 ___ ___ Python-bugs-list mailing list

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: Ping myself. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18294 ___ ___ Python-bugs-list mailing list

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: The I parser format does not check for integer overflow. The O format can be used with _PyLong_AsInt() instead. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18294

[issue18294] zlib module is not completly 64-bit safe

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Extension Modules nosy: +nadeem.vawda stage: - patch review type: - behavior versions: +Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: @Serhiy: Oh, thanks for your review. My patch was far from being perfect, a review was necessary! (I hesitated to commit it directly.) Here is a new patch using unsigned int is most places, parsing arguments with I format, and explicit cast to (size_t) to not

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: Here is a new patch using unsigned int is most places, parsing arguments with I format, and explicit cast to (size_t) to not compare unsigned with signed. Oh oh, it's still wrong. The I parser format does not check for integer overflow. _PyBytes_Resize() also

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: Related issue: #9566. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18294 ___ ___ Python-bugs-list mailing

[issue18294] zlib module is not completly 64-bit safe

New submission from STINNER Victor: Attached patch fixes different compiler warnings on Windows x64 in the zlib module. The module raises OverflowError if some values are longer than INT_MAX, but not all parameters are checked. -- files: zlib_64bit.patch keywords: patch messages:

[issue18294] zlib module is not completly 64-bit safe

STINNER Victor added the comment: The changeset 931e1bc090f6 fixes warnings in adler32 and crc32. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18294 ___