Tomasz Maćkowiak added the comment:
Attached patch with renamed test methods (as per Brett's review).
--
Added file: http://bugs.python.org/file30840/bug18342_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
Tomasz Maćkowiak added the comment:
Attaching a test case and a patch for formatting the module name with
PyObject_Repr() not PyObject_Str().
--
keywords: +patch
nosy: +kurazu
Added file: http://bugs.python.org/file30794/bug18342.patch
___
Python
Tomasz Maćkowiak added the comment:
Attaching a modified patch with assertRaisesRegexp used.
--
Added file: http://bugs.python.org/file30796/bug18342_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
STINNER Victor added the comment:
The patch looks good to me. Just a minor nit: you should add ^ to the
beginning of the regex.
2013/7/6 Tomasz Maćkowiak rep...@bugs.python.org:
Tomasz Maćkowiak added the comment:
Attaching a modified patch with assertRaisesRegexp used.
--
Added
Tomasz Maćkowiak added the comment:
Attached a corrected patch with regexps modified.
--
Added file: http://bugs.python.org/file30806/bug18342_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
Brett Cannon added the comment:
Tomasz, can you sign the contributor agreement
(http://python.org/psf/contrib/contrib-form/) so we can commit your code?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
Tomasz Maćkowiak added the comment:
Signed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
___
___
Python-bugs-list mailing list
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
___
___
Python-bugs-list
New submission from Brett Cannon:
from re import bogus
Traceback (most recent call last):
File stdin, line 1, in module
ModuleNotFoundError: cannot import name bogus
Should have 'bogus' using the repr to match the other cases of
ModuleNotFoundError
--
assignee: brett.cannon
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18342
___
___
Python-bugs-list
11 matches
Mail list logo