[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Terry J. Reedy added the comment: This is working, so closing. I opened #18604 for consolidating gui checks in test.support. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset c57b2a344097 by Terry Jan Reedy in branch '3.3': Issue #18441: Remove check from test_text.py in 3.3,4 (already done in 2.7). http://hg.python.org/cpython/rev/c57b2a344097 -- ___ Python tracker

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset c3936a52f215 by Terry Jan Reedy in branch '3.3': Issue #18441: Make test.support.requires('gui') skip when it should. http://hg.python.org/cpython/rev/c3936a52f215 New changeset 858a72d91162 by Terry Jan Reedy in branch '2.7': Issue #18441: Move com

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Terry J. Reedy added the comment: I tried to run the currently unnecessary Mac 'darwin' check in 2.7 with if sys.platform == 'darwin': from lib-tk.test.runtktests import check_tk_availability # tkinter.test.suppport in 3.x try: check_tk_

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset 9a4c62c1a4c0 by Terry Jan Reedy in branch '2.7': Issue #18441: add Mac (darwin) gui check. This is not needed today, but has been http://hg.python.org/cpython/rev/9a4c62c1a4c0 New changeset ba5c264d67ea by Terry Jan Reedy in branch '2.7': Issue #184

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset dd9941f5fcda by Terry Jan Reedy in branch '2.7': Issue #18441: Make test.support.requires('gui') skip when it should. http://hg.python.org/cpython/rev/dd9941f5fcda New changeset d9a53ab464ea by Terry Jan Reedy in branch '2.7': Issue #18441: Correct

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Terry J. Reedy added the comment: More noise. Much of what I said above was incorrect due to version mixup. The one extra fix I did not commit might have been enough, but I will wait until I have tested it. -- stage: commit review -> patch review __

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Terry J. Reedy added the comment: (The fix was incomplete because 'delete' in the except clause should be 'remove'.) I finally realized that I could test the except clause by raising TclError explicitly just before it. I reverted both changes because they do not seem to work, even with the ad

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset e8b8279ca118 by Terry Jan Reedy in branch '2.7': Backed out changeset: 23b0164b9c82 #18441 not working http://hg.python.org/cpython/rev/e8b8279ca118 -- ___ Python tracker

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset 9f922270a929 by Terry Jan Reedy in branch '2.7': Issue #18441: fix buildbot name-error for TclError. http://hg.python.org/cpython/rev/9f922270a929 -- ___ Python tracker

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Terry J. Reedy added the comment: I took a look. Not fun ;-). Pending a more permanent fix, I am applying a revised patch, first to 2.7 to make sure it works. -- ___ Python tracker ___

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Roundup Robot added the comment: New changeset 23b0164b9c82 by Terry Jan Reedy in branch '2.7': Issue #18441: Make test.support.requires('gui') skip when it should. http://hg.python.org/cpython/rev/23b0164b9c82 -- nosy: +python-dev ___ Python tracker

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Changes by Todd Rovito : -- nosy: +philwebster ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Changes by Todd Rovito : -- nosy: +JayKrish ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

Ned Deily added the comment: See Issue8716 for the history of check_tk_availability(). At the time, the Tk tests were the only ones trying to create real Tk objects (and thus causing crashes on some buildbot configurations). With the addition of IDLE tests that call Tk, it probably makes sen

[issue18441] Idle: Make test.support.requires('gui') skip when it should.

New submission from Terry J. Reedy: This is a continuation of #18365, where it was discovered after the first set of pushes that test.support.requires('gui') is currently insufficient (on non-Windows systems) for skipping gui tests on buildbots when they should be skipped, because the attem