[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Nitika Agarwal added the comment: @Terry J.Reedy Thanks a lot.And yes, I will take care of it next time. -- ___ Python tracker ___ ___

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Terry J. Reedy added the comment: Nitika, congrats on first patch. One minor problem: spaces at end of lines. It it my fault for not checking, but try to avoid them anyway. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Roundup Robot added the comment: New changeset fdadc152b964 by Terry Jan Reedy in branch '2.7': Issue #18566: Clarify unittest setUp, tearDown doc. Patch by Nitika Agarwal. http://hg.python.org/cpython/rev/fdadc152b964 New changeset 9ab66a7f654a by Terry Jan Reedy in branch '3.4': Issue #18566:

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Changes by Terry J. Reedy : -- assignee: docs@python -> terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Michael Foord added the comment: Patch looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Nitika Agarwal added the comment: Hi, Please review the patch attached. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Nitika Agarwal added the comment: Hi, I am attaching a patch with the changes made as suggested by py.user. -- nosy: +nitika Added file: http://bugs.python.org/file34550/document18566.patch ___ Python tracker _

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

py.user added the comment: In proposed patches fix Skiptest -> :exc:`SkipTest` AssertionError -> :exc:`AssertionError` -- ___ Python tracker ___

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Changes by Sreepriya Chalakkal : Added file: http://bugs.python.org/file34420/doc18566.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Michael Foord added the comment: Yep, those docs are just wrong. I'm trying to think of a concise rewording. -- ___ Python tracker ___ ___

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

py.user added the comment: I have built 3.4.0a4 and run - same thing -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Julian Gindi added the comment: Sorry. I meant, merged. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Terry J. Reedy added the comment: Resolved in what way? The doc seems unchanged. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Julian Gindi added the comment: Looks like this issue has been resolved. Can we close it? -- ___ Python tracker ___ ___ Python-bugs-li

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Julian Gindi added the comment: I did some further testing and it seems that you are right, testcase.SkipTest() never causes an error in setUp or tearDown but "raise AssertionError" does (even in setUp or tearDown). I went ahead and made relevant documentation changes, let me know what you thi

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Terry J. Reedy added the comment: I re-ran with setUp 'raise' changed to 'pass' to see the effect of raise AssertionError or unittest.SkipTest in tearDown and indeed the test fails or skips even then. I suggest adding ', other than AssertionError or SkipTest,' just after 'method'. The same is

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti, michael.foord stage: -> needs patch ___ Python tracker ___ ___ Pyth

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

New submission from py.user: http://docs.python.org/3/library/unittest.html#unittest.TestCase.setUp "any exception raised by this method will be considered an error rather than a test failure" http://docs.python.org/3/library/unittest.html#unittest.TestCase.tearDown "Any exception raised by thi