Nitika Agarwal added the comment:
@Terry J.Reedy
Thanks a lot.And yes, I will take care of it next time.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
Michael Foord added the comment:
Patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Python-bugs-list mailing
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: docs@python - terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Roundup Robot added the comment:
New changeset fdadc152b964 by Terry Jan Reedy in branch '2.7':
Issue #18566: Clarify unittest setUp, tearDown doc. Patch by Nitika Agarwal.
http://hg.python.org/cpython/rev/fdadc152b964
New changeset 9ab66a7f654a by Terry Jan Reedy in branch '3.4':
Issue #18566:
Terry J. Reedy added the comment:
Nitika, congrats on first patch. One minor problem: spaces at end of lines. It
it my fault for not checking, but try to avoid them anyway.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
Nitika Agarwal added the comment:
Hi,
Please review the patch attached.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Nitika Agarwal added the comment:
Hi,
I am attaching a patch with the changes made as suggested by py.user.
--
nosy: +nitika
Added file: http://bugs.python.org/file34550/document18566.patch
___
Python tracker rep...@bugs.python.org
py.user added the comment:
In proposed patches fix
Skiptest - :exc:`SkipTest`
AssertionError - :exc:`AssertionError`
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
Changes by Sreepriya Chalakkal sreepriya1...@gmail.com:
Added file: http://bugs.python.org/file34420/doc18566.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
Michael Foord added the comment:
Yep, those docs are just wrong. I'm trying to think of a concise rewording.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
Julian Gindi added the comment:
Looks like this issue has been resolved. Can we close it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
Terry J. Reedy added the comment:
Resolved in what way? The doc seems unchanged.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Julian Gindi added the comment:
Sorry. I meant, merged.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Python-bugs-list mailing
py.user added the comment:
I have built 3.4.0a4 and run - same thing
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Julian Gindi added the comment:
I did some further testing and it seems that you are right, testcase.SkipTest()
never causes an error in setUp or tearDown but raise AssertionError does
(even in setUp or tearDown). I went ahead and made relevant documentation
changes, let me know what you
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Python-bugs-list
Terry J. Reedy added the comment:
I re-ran with setUp 'raise' changed to 'pass' to see the effect of raise
AssertionError or unittest.SkipTest in tearDown and indeed the test fails or
skips even then. I suggest adding ', other than AssertionError or SkipTest,'
just after 'method'. The same is
New submission from py.user:
http://docs.python.org/3/library/unittest.html#unittest.TestCase.setUp
any exception raised by this method will be considered an error rather than a
test failure
http://docs.python.org/3/library/unittest.html#unittest.TestCase.tearDown
Any exception raised by this
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +easy
nosy: +ezio.melotti, michael.foord
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
19 matches
Mail list logo