[issue18576] Rename and document test.script_helper as test.support.script_helper

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue18576] Rename and document test.script_helper as test.support.script_helper

Nick Coghlan added the comment: The attached patch just moves the file without leaving an alias behind. It turns out we use this one in a fair few places (mostly for "assert_python_ok"). I'm going to sit on this change for the moment - after reading the docs, it's quite clear that the last cou

[issue18576] Rename and document test.script_helper as test.support.script_helper

Nick Coghlan added the comment: Note that the test.* namespace has long been declared as unstable, so we don't worry about breaking third party code when rearranging the test suite (as far as I am aware, most Linux distros don't even include the test suite in their Python packages). I'll see how

[issue18576] Rename and document test.script_helper as test.support.script_helper

Fotis Koutoulakis added the comment: Taking the feedback during code review, this is a patch that has the points raised by Serhiy Storchaka fixed. As always, please do note omission or mistakes from my part. Thanks for your help. -- Added file: http://bugs.python.org/file33057/issue18

[issue18576] Rename and document test.script_helper as test.support.script_helper

Serhiy Storchaka added the comment: > Does the last patch meet your expectations, or would you rather see all these > changes implemented at once? I left this for Nick. I have added comments on Rietveld. -- stage: needs patch -> patch review ___ Py

[issue18576] Rename and document test.script_helper as test.support.script_helper

Fotis Koutoulakis added the comment: Oh, I see. Does the last patch meet your expectations, or would you rather see all these changes implemented at once? -- ___ Python tracker

[issue18576] Rename and document test.script_helper as test.support.script_helper

Serhiy Storchaka added the comment: Third party code can use tests.script_helper. I prefer to do these changes in several steps: 1) Move script_helper.py to Lib/test/support/, document it, and create an alias (with deprecation warning). 2) Ensure that this doesn't break any buildbot. 3) Change

[issue18576] Rename and document test.script_helper as test.support.script_helper

Fotis Koutoulakis added the comment: Ok, here is the second (modified patch) which contains a script so that no modifications are required to existing tests. I am uploading it as a second patch, so that the first one is left as a reference. As a sidenote, I fail to see convincing reasons for

[issue18576] Rename and document test.script_helper as test.support.script_helper

Serhiy Storchaka added the comment: Please left test.script_helper as alias to test.support.script_helper. I.e. test/script_helper.py should contains something like: from test.support.script_helper import * And test this with unmodifiable other tests. -- nosy: +serhiy.storchaka _

[issue18576] Rename and document test.script_helper as test.support.script_helper

Fotis Koutoulakis added the comment: Hello again. Is everything ok with the patch? Is there something not working as expected? Perhaps an omission or something? Do I need to do something more to get it accepted? Thanks for your time. -- ___ Python

[issue18576] Rename and document test.script_helper as test.support.script_helper

Changes by Nick Coghlan : -- assignee: docs@python -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18576] Rename and document test.script_helper as test.support.script_helper

Nick Coghlan added the comment: I wouldn't worry about 3.3 at this point - the 3.3 test suite isn't going to see major changes for its final release, so the risk of merge conflicts is low. -- versions: -Python 3.3 ___ Python tracker

[issue18576] Rename and document test.script_helper as test.support.script_helper

Fotis Koutoulakis added the comment: I have finished the changes needed to move script_helper from Lib/test to Lib/test/support, and I have also documented it. Tests run gracefully (but be sure to check out if it works as intended on your machines too) Two notes though: 1. I have only made th

[issue18576] Rename and document test.script_helper as test.support.script_helper

Seydou Dia added the comment: Since I am already on bugs.python.org/issue18578 I will tackle this issue, if you don't mind. -- nosy: +seydou ___ Python tracker ___ _

[issue18576] Rename and document test.script_helper as test.support.script_helper

Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue18576] Rename and document test.script_helper as test.support.script_helper

New submission from Nick Coghlan: tests.script_helper provides various utilities for sensibly testing scripts in a subprocess. It isn't easy for CPython developers to discover, since it is isn't documented and the file is mixed in with actual tests in the main test directory. As discussed in