[issue18725] Multiline shortening

Serhiy Storchaka added the comment: Thank you Vajrasky. It's Antoine forgot. ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18725] Multiline shortening

Roundup Robot added the comment: New changeset 0bd257cd3e88 by Serhiy Storchaka in branch 'default': Add shorten to __all_ (issues #18585 and #18725). http://hg.python.org/cpython/rev/0bd257cd3e88 -- ___ Python tracker

[issue18725] Multiline shortening

Vajrasky Kok added the comment: Serhiy, you forgot to add shorten to __all__. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: Antoine has approved this on IRC. Thank you Ezio and Antoine for your reviews. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue18725] Multiline shortening

Roundup Robot added the comment: New changeset 2e8c424dc638 by Serhiy Storchaka in branch 'default': Issue #18725: The textwrap module now supports truncating multiline text. http://hg.python.org/cpython/rev/2e8c424dc638 -- ___ Python tracker

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: In updated patch fixed a bug with final spaces. -- assignee: -> serhiy.storchaka Added file: http://bugs.python.org/file31971/textwrap_max_lines_2.patch ___ Python tracker _

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: Could anyone please review the patch? -- keywords: +needs review ___ Python tracker ___ ___ Python

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: Here is a patch. It get rid of TextWrap.shorten() because TextWrap.fill() supersedes it and because "placeholder" now a parameter of TextWrap. Module level shorten() is left but I doubt about it. -- keywords: +patch stage: test needed -> patch review

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: fill(...) is just '\n'.join(wrap(...)). Directly use wrap() if you need nonstandard newlines. -- ___ Python tracker ___ _

[issue18725] Multiline shortening

Vajrasky Kok added the comment: What about newline keyword argument? Are we forcing the newline to be '\n'? Alternate newlines will be useful for Windows platform ('\r\n') and HTML platform (''). -- ___ Python tracker

[issue18725] Multiline shortening

Changes by Serhiy Storchaka : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue18725] Multiline shortening

Antoine Pitrou added the comment: Sounds like a reasonable enhancement to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18725] Multiline shortening

New submission from Serhiy Storchaka: Functions in the textwrap module works with multiline text except a newly added (in issue18585) the shorten() function. Wrapping and shortening a multiline text using existing textwrap function is not a trivial job. I propose to add two new parameters to t