Roundup Robot added the comment:
New changeset ac6dab1819c4 by Raymond Hettinger in branch 'default':
Issue 18797: Remove unneeded refcount adjustments for dummy objects.
http://hg.python.org/cpython/rev/ac6dab1819c4
--
nosy: +python-dev
___
Python
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18797
___
New submission from Raymond Hettinger:
AFAICT, there is no reason for sets to incref and decref dummy objects. The
dummy object address is used as placeholders in the hash table but it is never
accessed by set the logic. As long the one reference is held at the time the
dummy object is
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18797
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +Mark.Shannon, tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18797
___
___
Antoine Pitrou added the comment:
I can't think of any counter-indication but I think we shouldn't distinguish
between debug and non-debug mode. That way the debug hooks can check that the
refcounting optimization is right.
--
___
Python tracker
Raymond Hettinger added the comment:
I think we shouldn't distinguish between debug and non-debug mode.
That makes good sense.
Attaching a new patch without the #ifdefs.
--
Added file: http://bugs.python.org/file31402/no_refcnt_dummy2.diff
___
