Thomas Heller added the comment:
I suggest to remove the comment part from the patch and then apply it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18852
___
Roundup Robot added the comment:
New changeset 3070fdd58645 by R David Murray in branch 'default':
#18852: Handle readline.__doc__ being None in site.py readline activation.
http://hg.python.org/cpython/rev/3070fdd58645
--
nosy: +python-dev
___
R. David Murray added the comment:
Done. Thanks, Berker.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18852
Antoine Pitrou added the comment:
Thanks David! I had forgotten about the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18852
___
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18852
___
___
Berker Peksag added the comment:
Here's a patch with a comment about using pyreadline on Windows.
Should the note in the readline documentation[1] be updated?
[1] http://docs.python.org/3.4/library/readline.html
(See also issue 5845 and msg123703)
--
keywords: +patch
stage: needs
Ned Deily added the comment:
The use of libedit is not restricted to OS X; in particular, some other
BSD-derived distributions use it. There are some other open issues regarding
generalization of support for libedit. So I don't think the proposed comments
should be added to site.py. The
R. David Murray added the comment:
I don't think __doc__ can ever not exist, so that code is just wrong :)
--
keywords: +easy
nosy: +r.david.murray
stage: - needs patch
title: Problem with pyreadline - site.py does not handle readline.__doc__
being None
