[issue18910] IDle: test textView.py

Terry J. Reedy added the comment: I have stopped patching IDLE for 2.7 and will not add more tests. So there is no reason to constrain tests for 3.5, and soon 3.6, to 2.7 limitations. -- assignee: -> terry.reedy resolution: -> fixed stage: needs patch -> resolved status: open -> clos

[issue18910] IDle: test textView.py

Roundup Robot added the comment: New changeset f5e20abea871 by Terry Jan Reedy in branch '2.7': Issue 18910: Edit idle_test/README.txt to add 'requires' warning. https://hg.python.org/cpython/rev/f5e20abea871 New changeset 735eebce6765 by Terry Jan Reedy in branch '3.5': Issue 18910: Edit idle_t

[issue18910] IDle: test textView.py

Terry J. Reedy added the comment: Yes, early skipping was the reason I put the test where I did. The simple change occurred to me today. I have not decided yet whether to also change the 3.4/5 files to match and how to edit the testing README. For one test, I would not care either way. But I e

[issue18910] IDle: test textView.py

Zachary Ware added the comment: The changeset Benjamin backed out is pretty much fine, just needs the requires('gui') to be at the top of setUpModule instead of at toplevel. That does mean the whole module is constructed and then thrown away without doing anything, but it at least runs proper

[issue18910] IDle: test textView.py

Roundup Robot added the comment: New changeset a0be81607a50 by Benjamin Peterson in branch '2.7': backed out 86ba41b7bb46 (#18910) for test breakage http://hg.python.org/cpython/rev/a0be81607a50 -- ___ Python tracker

[issue18910] IDle: test textView.py

Terry J. Reedy added the comment: The 3.4 stable buildbots are green except for two that ran test_idle ok. The problem is that in 2.7, unittest.loader does not catch ResourceDenied at module level whereas is does in 3.4. The only indication that there should be a difference is that the 3.x doc

[issue18910] IDle: test textView.py

Changes by Serhiy Storchaka : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue18910] IDle: test textView.py

Serhiy Storchaka added the comment: Please don't create Tk object at module creating stage. I afraid this will break unittest discoverity. -- nosy: +serhiy.storchaka ___ Python tracker

[issue18910] IDle: test textView.py

Ned Deily added the comment: It looks like the 2.7 checkin has caused a number of buildbots to fail. Examples: http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%202.7/builds/1094/steps/test/logs/stdio == ERROR: idl

[issue18910] IDle: test textView.py

Roundup Robot added the comment: New changeset 86ba41b7bb46 by Terry Jan Reedy in branch '2.7': Issue #18910: test_textView - since all tests require 'gui', make root global. http://hg.python.org/cpython/rev/86ba41b7bb46 New changeset 5a46ebfa5d90 by Terry Jan Reedy in branch '3.4': Issue #18910

[issue18910] IDle: test textView.py

Terry J. Reedy added the comment: Since all tests create a widget with widgets (or destroy it), the new patch moves root to class scope and simplifies the code a bit. It also subclasses TextViewer instead of monkey-patching it. Modules have to be monkey-patched because they cannot be 'sub-modu

[issue18910] IDle: test textView.py

Terry J. Reedy added the comment: The use of .__new__ was cute. Unfortunately, it did not backport to 2.7 because tkinter classes were never upgraded from old to new in 2.7 and old-style classes do not have .__new__. So I monkeypatched the module instead, which is a but clumbsier than patching

[issue18910] IDle: test textView.py

Roundup Robot added the comment: New changeset 9ac57970ee4c by Terry Jan Reedy in branch '2.7': Issue #18910: Add unittest for textView. Patch by Phil Webster. http://hg.python.org/cpython/rev/9ac57970ee4c New changeset 99047f3a19a9 by Terry Jan Reedy in branch '3.4': Issue #18910: Add unittest

[issue18910] IDle: test textView.py

Changes by Terry J. Reedy : -- stage: -> patch review title: IDLE: Unit test for textView.py -> IDle: test textView.py versions: +Python 3.5 -Python 3.3 ___ Python tracker ___ _