Roundup Robot added the comment:
New changeset 0e0dded5d616 by R David Murray in branch '3.3':
#18985: Improve fcntl documentation.
http://hg.python.org/cpython/rev/0e0dded5d616
New changeset ddf6da99b3cd by R David Murray in branch 'default':
Merge #18985: Improve fcntl documentation.
R. David Murray added the comment:
Thanks, Vajrasky (and Victor :)
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
R. David Murray added the comment:
Vajrasky: what do you think of my version? Is it clear enough?
I wonder if we want to document the constants someday.
--
stage: - patch review
versions: +Python 2.7, Python 3.3
___
Python tracker
Vajrasky Kok added the comment:
Except for the typo noticed by Victor, your patch looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
___
R. David Murray added the comment:
Here's my suggestion.
--
Added file: http://bugs.python.org/file32442/fcntl-doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
___
___
Vajrasky Kok added the comment:
Updated patch based on Ezio's review. I reverted back the changes to Nul and
module documentation (since it is not so clear whether we should categorize
flock as Unix routine or not).
--
Added file:
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
___
___
New submission from Vajrasky Kok:
The attached patch fixed typos and improved the documentation to improve the
clarity in Modules/fcntlmodule.c.
Please see the attached patch and feel free to disagree with the improvement.
--
assignee: docs@python
components: Documentation
files:
