Terry J. Reedy added the comment:
I am assuming that Serhiy meant to close this.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
Roundup Robot added the comment:
New changeset ff70c298dd60 by Serhiy Storchaka in branch '2.7':
Issue #19020: Tkinter now uses splitlist() instead of split() in configure
http://hg.python.org/cpython/rev/ff70c298dd60
New changeset a8f5f8c44dc8 by Serhiy Storchaka in branch '3.3':
Issue #19020:
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - commit review
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
Serhiy Storchaka added the comment:
If there are no objections I'll commit these patches tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
Serhiy Storchaka added the comment:
What is your opinion, Terry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
___
Python-bugs-list
Terry J. Reedy added the comment:
What I think:
1. Perhaps I should have noticed that
self.tk.call(_flatten((self._w, cmd:
has 3 '('s and 4 ')'s and looked at the previous line for the complete
expression.
2. Perhaps Python should switch os.sep ('\\') and os.altsep ('/') on
Serhiy Storchaka added the comment:
Sanitizing backslashes will not help when file names (or other returned
strings, see msg202496) contains spaces or curly braces.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
Serhiy Storchaka added the comment:
And of cause we can't sanitize filenames which contains backslash on Unix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
Terry J. Reedy added the comment:
I read your explanation in relation to the code and got part of it but not all.
I need to try another run through. I may try to locally (and temporarily),
print to the console to see what is happening.
I am also not clear on the relation between the
Serhiy Storchaka added the comment:
I am also not clear on the relation between the UnicodeDecodeError and tuple
splitting. Does '_flatten((self._w, cmd)))' call split or splitlist on the
tuple arg? Is so, do you know why a problem with that would lead to the
UDError? Does your patch fix
Serhiy Storchaka added the comment:
Tests added in issue19085 have a special case for tuple values because
widget[name] and widget.configure(name) return different results in such cases.
When remove this special case, following tests fails:
Serhiy Storchaka added the comment:
Tcl is weak typed language and all Tcl values formally are strings. 123 is
the 123 integer, the 123 string, and Tcl list containing one element 123
(which can be a number, a string, a list, etc). Actually for optimization Tcl
uses different specialized
Serhiy Storchaka added the comment:
What would you say about this patch Terry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
___
Serhiy Storchaka added the comment:
What would you say about this patch Terry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
Removed message: http://bugs.python.org/msg198805
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
Terry J. Reedy added the comment:
I cannot say much since I do not know what .split and .splitlist do or are
supposed to do. They have no docstrings. They are methods of tkinter.Tk().tk,
the app or 'interpreter' returned by _tkinter.create. Modules/_tkinker.c maps
then to the C functions
Serhiy Storchaka added the comment:
There are two methods: splitlist() and split(). The splitlist() method splits
only one level and always returns a tuple (even if it is empty or one-element).
The split() method splits recursive and can returns a string if it is not
splittable. I.e. result
New submission from Terry J. Reedy:
Current 3.3.2+ repository build (32 bit) and 3.4.0a2 repository build (32 bit)
and installation (64 bit) have a problem that did not exist in my Win6 3.3.2
installation (64 bit). (Bruce Sherwood discovered the symption with some
installed version of
Serhiy Storchaka added the comment:
Perhaps this is caused by issue18101.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19020
___
___
19 matches
Mail list logo