Roundup Robot added the comment:
New changeset 3589980c98de by Victor Stinner in branch 'default':
Issue #19977, #19036: Always include locale.h in pythonrun.c
http://hg.python.org/cpython/rev/3589980c98de
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset f82b6ec1ae6e by Stefan Krah in branch '3.3':
Issue #19036: Including locale.h should not depend on HAVE_LANGINFO_H.
http://hg.python.org/cpython/rev/f82b6ec1ae6e
--
nosy: +python-dev
___
Python tracker
Changes by Stefan Krah stefan-use...@bytereef.org:
--
resolution: remind - fixed
stage: - committed/rejected
status: open - closed
type: - compile error
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
Changes by Alan Hourihane al...@fairlite.co.uk:
--
resolution: - remind
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
___
___
Stefan Krah added the comment:
The patch looks correct to me. locale.h is at least C99 (I don't have the
earlier standards).
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
New submission from Alan Hourihane:
Patch
--- Python/fileutils.c.old 2013-09-11 07:04:42.0 +
+++ Python/fileutils.c 2013-09-11 07:05:01.0 +
@@ -4,8 +4,8 @@
# include windows.h
#endif
-#ifdef HAVE_LANGINFO_H
#include locale.h
+#ifdef HAVE_LANGINFO_H
R. David Murray added the comment:
Oops, didn't mean to assign this to anyone.
--
assignee: lemburg -
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
___
R. David Murray added the comment:
Can you provide more information about the circumstances in which this is a
problem? Presumably there is a reason why the code is currently the way it is,
especially since it is done this way in several of the source files, and has
been that way for a
Alan Hourihane added the comment:
Oops, meant to say.
In pythonrun.c the setlocale() call is already wrapped inside the #ifdef so the
problem ISN'T bumped into there.
--
___
Python tracker rep...@bugs.python.org
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: -lemburg
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
___
___
Python-bugs-list
R. David Murray added the comment:
So the real problem is that the setlocale call is outside the ifdef, which
means Victor is the right person to look at this, since it was his patch that
introduced the code in question. I'll remove MAL from nosy, since I only added
him by accident.
Alan Hourihane added the comment:
Yes, it's a Build issue as mentioned using the Components field.
But cut pasting from other files is incorrect in this case because
setlocale() is still used outside of the #ifdef.
File attached.
--
keywords: +patch
Added file:
Alan Hourihane added the comment:
You'll see the error on any platform that doesn't include locale.h when it
should, i.e. a platform that doesn't have NL_LANGINFO. This is the build
error.
Python/fileutils.c: In function 'check_force_ascii':
Python/fileutils.c:101:5: warning: implicit
STINNER Victor added the comment:
Yes, it's a Build issue as mentioned using the Components field.
Again, what is your platform (OS name, OS version)?
What is the compiler error message?
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
versions: +Python 3.2, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
___
STINNER Victor added the comment:
Oh by the way, please attach the patch as a file to the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19036
___
STINNER Victor added the comment:
It looks like a real issue, but on which platform did you get the error?
setlocale fails due to locale.h being wrapped up in LANGINFO check.
What do you mean by fail? Is it an error at runtime? Or during the
compilation?
--
The include was added recently:
Alan Hourihane added the comment:
Sure, Look in the function.
check_force_ascii()
You'll see a hunk of code that is ifdef'd for ...
#if defined(HAVE_LANGINFO_H) defined(CODESET)
Then you'll see
setlocale()
is called outside of that check, just before another hunk of code is
ifdef'd
18 matches
Mail list logo
