Serhiy Storchaka added the comment:
Thank you Net, Vajrasky and Zachary for your help for testing.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
What's the status here? Appears to be fixed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Ned Deily added the comment:
All of the failures I reported are now fixed so I think this issue can be
closed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
Ned Deily added the comment:
I've opened Issue19761 to document the current state of test failures for
3.4.0b1 on OS X with the native Tk 8.5 and 8.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
Serhiy Storchaka added the comment:
test_widgets.ButtonTest is still causing a Cocoa Tk 8.5/8.6 crash which also
crashes Python while running the test suite. The test should be fixed or
disabled.
Opened issue19733 for this.
--
___
Python tracker
Ned Deily added the comment:
test_widgets.ButtonTest is still causing a Cocoa Tk 8.5/8.6 crash which also
crashes Python while running the test suite. The test should be fixed or
disabled.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Crashes? It should be separate issue, no one Tkinter operation shouldn't crash
Python.
Fill free to disable this tests on MacOSX (or better on more specific
environment) if they prevent the test suite from running.
--
Ned Deily added the comment:
See msg202006 above.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset be8f9beca8aa by Serhiy Storchaka in branch '2.7':
Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.11 (issue #19085).
http://hg.python.org/cpython/rev/be8f9beca8aa
New changeset 204e66190dbb by Serhiy Storchaka in branch '3.3':
Fix Tkinter tests on
Zachary Ware added the comment:
Looks like the last commit broke 8.5.15 on Windows; in particular, on line 25
of widget_tests.py, int_round doesn't exist. Replacing 'int_round' with
'round' allows most tests to pass, but I still get these two failures:
Roundup Robot added the comment:
New changeset d5d0356ba5ac by Serhiy Storchaka in branch '3.3':
Fix typo in tkinter tests (issue #19085).
http://hg.python.org/cpython/rev/d5d0356ba5ac
New changeset fc4ef17c7db8 by Serhiy Storchaka in branch 'default':
Fix typo in tkinter tests (issue #19085).
Serhiy Storchaka added the comment:
Thank you Zachary.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset eb126f976fa2 by Serhiy Storchaka in branch '2.7':
Fix test_insertwidth Tkinter tests on Tk 8.5 with patchlevel = 8.5.12 (issue
#19085).
http://hg.python.org/cpython/rev/eb126f976fa2
New changeset 21fbe3ec90dc by Serhiy Storchaka in branch '3.3':
Zachary Ware added the comment:
Working from ce08158e3f6c with 8.5.15 on Windows, I get the same failures with
a different AssertionError:
==
FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.EntryTest)
Zachary Ware added the comment:
FTR, both 8.5.11 and 8.6.1 pass all tests on Windows from ce08158e3f6c (with
unrelated modifications required to build and use 8.6.1).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
Roundup Robot added the comment:
New changeset c97600bdd726 by Serhiy Storchaka in branch '2.7':
Revert wrong change in previous commit (issue #19085).
http://hg.python.org/cpython/rev/c97600bdd726
New changeset bec6df56c053 by Serhiy Storchaka in branch '3.3':
Revert wrong change in previous
Serhiy Storchaka added the comment:
My fault. I missed that here is simple checkParam() instead of
checkPixelsParam(). Thank you Zachary.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
Roundup Robot added the comment:
New changeset c3fa22d04fb2 by Serhiy Storchaka in branch '2.7':
Issue #19085: Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.12.
http://hg.python.org/cpython/rev/c3fa22d04fb2
New changeset 583347b79aa0 by Serhiy Storchaka in branch '3.3':
Issue #19085: Fix
Roundup Robot added the comment:
New changeset fe7aaf14b129 by Serhiy Storchaka in branch '2.7':
Issue #19085: Fix running test_ttk_textonly on displayless host.
http://hg.python.org/cpython/rev/fe7aaf14b129
New changeset 47d3714dcb33 by Serhiy Storchaka in branch '3.3':
Issue #19085: Fix
Ned Deily added the comment:
With Cocoa Tk 8.5.15 or Cocoa Tk 8.6.1 on OS X 10.8.5, test_widgets.ButtonTest
crashes Tk:
test_image (tkinter.test.test_tkinter.test_widgets.ButtonTest) ... 2013-11-03
01:52:53.498 pytest_10.8[82465:f07] *** Assertion failure in -[NSBitmapImageRep
Serhiy Storchaka added the comment:
Yes, I know. Here is a list of broken buildbots:
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x
http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%203.x
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.3
Vajrasky Kok added the comment:
Serhiy,
In Python3.4, Windows Vista 32 bit, Release Mode, Tcl/Tk 8.5.15, I got a lot of
errors. However, if I set _conv_pixels to round in
Lib/tkinter/test/widget_tests.py, everything works fine.
In Python 3.4, Fedora 18, Debug Mode, Tcl/Tk 8.5.13, I got a lot
Roundup Robot added the comment:
New changeset a34889a30d52 by Serhiy Storchaka in branch '2.7':
Issue #19085: Fixed pixels rounding for last Tk patchlevels.
http://hg.python.org/cpython/rev/a34889a30d52
New changeset dfdf47a9aad4 by Serhiy Storchaka in branch '3.3':
Issue #19085: Fixed pixels
Serhiy Storchaka added the comment:
Thanks Vajrasky. Now I see that this is a bug in Tk 8.5 which was fixed in
8.5.12. We should use round() to conform with last Tk patchlevels. However this
breaks tests on Ubuntu 12.04 LTS which uses 8.5.11.
Here is a patch which adds workaround for this
Roundup Robot added the comment:
New changeset 92e268f2719e by Serhiy Storchaka in branch '3.3':
Issue #19085: Added basic tests for all tkinter widget options.
http://hg.python.org/cpython/rev/92e268f2719e
New changeset ab7c2c1d349c by Serhiy Storchaka in branch 'default':
Issue #19085: Added
Roundup Robot added the comment:
New changeset cee56ef59a6a by Serhiy Storchaka in branch 'default':
Issue #19085. Try to fix tkinter tests on Windows.
http://hg.python.org/cpython/rev/cee56ef59a6a
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 278d15021d9a by Serhiy Storchaka in branch '2.7':
Issue #19085: Fix Tkinter tests with Tcl/Tk 8.4.
http://hg.python.org/cpython/rev/278d15021d9a
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset f25679db52fb by Serhiy Storchaka in branch '3.3':
Issue #19085: Fixed some Tkinter tests on Windows.
http://hg.python.org/cpython/rev/f25679db52fb
New changeset 4a2afda8f187 by Serhiy Storchaka in branch '2.7':
Issue #19085: Fixed some Tkinter
Serhiy Storchaka added the comment:
Updated patch addresses Ezio's comments.
--
Added file: http://bugs.python.org/file32441/tkinter_options_tests_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file32379/tkinter_options_tests_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
Serhiy Storchaka added the comment:
Updated patch fixes issues for Tk 8.4 and skipped ttk.Scrollbar test on MacOSX.
I have increased the priority because many Tkinter issues will benefit from
these tests.
--
priority: normal - high
___
Python
Ned Deily added the comment:
With Aqua Cocoa Tcl/Tk 8.5.14 or 8.6.0 (using ActiveState's 8.5.14 or 8.6.0) on
OS X 10.8.5, running test_ttk_guionly:
==
ERROR: test_class (tkinter.test.test_ttk.test_widgets.ScrollbarTest)
Serhiy Storchaka added the comment:
Thank you Ned.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
If there are no objections I'm going to commit this.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
New submission from Serhiy Storchaka:
The proposed patch adds tests for all options of all widgets. They test that
widgets support all documented options, accepts valid values in different
formats, reject invalid values, and return values in expected format. This
would be helpful for
Changes by Ned Deily n...@acm.org:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Python-bugs-list mailing list
36 matches
Mail list logo
