[issue19184] dis module has incorrect docs for RAISE_VARARGS

Ezio Melotti added the comment: Fixed, thanks for the report and the PRs! -- assignee: docs@python -> ezio.melotti resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement versions: +Python 3.7 ___ Python

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Ezio Melotti added the comment: New changeset 9390e98c3ed9eb9fa414030a2feec1926193af94 by Ezio Melotti (Miss Islington (bot)) in branch '3.7': bpo-19184: Update the documentation of dis module. (GH-13652) (GH-13755)

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Change by miss-islington : -- pull_requests: +13636 pull_request: https://github.com/python/cpython/pull/13755 ___ Python tracker ___

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Ezio Melotti added the comment: New changeset e1179a5096fb12297ececd7a1c79969aa5747e28 by Ezio Melotti (Michele Angrisano) in branch 'master': bpo-19184: Update the documentation of dis module. (GH-13652) https://github.com/python/cpython/commit/e1179a5096fb12297ececd7a1c79969aa5747e28

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Change by Michele Angrisano : -- keywords: +patch pull_requests: +13544 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13652 ___ Python tracker

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Michele Angrisano added the comment: I'm working on it. -- nosy: +mangrisano ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Cheryl Sabella added the comment: The original PR appears to have been abandoned, so this issue available for someone to submit a new PR. -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 2.7, Python 3.5, Python 3.6, Python 3.7 ___ Python

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Louie Lu added the comment: I've made a PR, could serhiy or georg help for review? Thanks! -- nosy: +louielu ___ Python tracker ___

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Serhiy Storchaka added the comment: May be just provide Python statements that correspond different numbers of parameters? 0 -- ``raise``, 1 -- ``raise TOS``, 2 -- ``raise TOS1 from TOS``. -- nosy: +serhiy.storchaka ___ Python tracker

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Changes by Louie Lu : -- pull_requests: +1288 ___ Python tracker ___ ___ Python-bugs-list

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Changes by Serhiy Storchaka : -- stage: -> needs patch versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Tyler B added the comment: I wanted to make an edit so here's my revised comment: Looked at the code and found differences between 3.4 and 2.7. 2.7 has 4 exceptions that can be raised while 3.4 has 3 exceptions. I propose removing the list of parameters from the documenation to keep things

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Tyler B added the comment: One last edit: Looked at the code and found differences between 3.4 and 2.7. 2.7 has 4 exceptions that can be raised while 3.4 has 3 exceptions. I propose including the full list of parameters but describing the exceptions in a way that's less specific about the

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Georg Brandl added the comment: Tyler, thanks for the suggestion. However it doesn't really solve the issue: the parameter order is the opposite of the current doc text (and your suggested text). -- nosy: +georg.brandl ___ Python tracker

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Tyler B added the comment: Here's a revised suggestion that has the order changed. I have additional concerns but please provide comment on this revision. Thanks # 2.7 Raises an exception. argc indicates the number of parameters to the raise statement, ranging from 0 to 3. The parameters can

[issue19184] dis module has incorrect docs for RAISE_VARARGS

Tyler B added the comment: Looked at the code and found differences between 3.4 and 2.7. 2.7 has 3 exceptions that can be raised while 3.4 has 4 exceptions. I propose removing the list of parameters from the documenation to keep things simple and not repeat the code. # 2.7 Raises an

[issue19184] dis module has incorrect docs for RAISE_VARARGS

New submission from Ned Batchelder: The order of values on the stack is backwards for RAISE_VARARGS. The docs say: Raises an exception. argc indicates the number of parameters to the raise statement, ranging from 0 to 3. The handler will find the traceback as TOS2, the parameter as TOS1, and