Guido van Rossum added the comment:
OK, I've created issue 19334 to track test_asyncio hangs on other platforms.
Let's please keep this issue restricted to AIX. I am aware of the following
issue:
- select for read on the write end of a pipe returns immediately
Any other AIX issues also
Guido van Rossum added the comment:
@Richard: socketpair() seems to work fine on AIX (we use it internally). Maybe
we can always use that for subprocess management? But will the subprocess
module support this?
--
___
Python tracker
Changes by Florent Xicluna florent.xicl...@gmail.com:
--
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
___
Python-bugs-list
Richard Oudkerk added the comment:
The following uses socketpair() instead of pipe() for stdin, and works for me
on Linux:
diff -r 7d94e4a68b91 asyncio/unix_events.py
--- a/asyncio/unix_events.pySun Oct 20 20:25:04 2013 -0700
+++ b/asyncio/unix_events.pyMon Oct 21 17:15:19 2013 +0100
Guido van Rossum added the comment:
Brilliant. It works for me too on OS X.
David, can you check this on AIX?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Attached is a version of Richard's patch that I like better (sockpair.diff).
- instead of dropping the ValueError, check for ISFIFO and ISSOCK
- pass the read end of the socket pair to Popen()
--
Added file:
Changes by Guido van Rossum gu...@python.org:
Removed file: http://bugs.python.org/file32282/sockpair.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
New, improved version of sockpair.diff.
--
Added file: http://bugs.python.org/file32284/sockpair.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
David Edelsohn added the comment:
The testsuite is hanging in test_asyncio again and
test_subprocess_close_client_stream needs to be skipped.
--
Added file: http://bugs.python.org/file32289/issue19293.patch2
___
Python tracker rep...@bugs.python.org
David Edelsohn added the comment:
Other than the skipped tests, test_asyncio now passes on AIX except for:
FAIL: test_write_pipe (test.test_asyncio.test_events.PollEventLoopTests)
--
Traceback (most recent call last):
File
Guido van Rossum added the comment:
Thanks; I've applied and pushed your fix for the hang.
I think it's time to commit the sockpair.diff change; the test_write_pipe()
failure looks related -- as you recall the problem doesn't really cause a hang,
it causes a premature closing of a write pipe,
Roundup Robot added the comment:
New changeset 2a0bda8d283d by Guido van Rossum in branch 'default':
Switch subprocess stdin to a socketpair, attempting to fix issue #19293 (AIX
hang).
http://hg.python.org/cpython/rev/2a0bda8d283d
--
___
Python
Guido van Rossum added the comment:
Let's see how this fares. If it passes on the AIX buildbot, maybe see which of
the tests we skipped on AIX can be re-enabled again?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
David Edelsohn added the comment:
With the latest changeset applied to default, the test_subprocess tests no
longer hang, but test_write_pipe_disconnect_on_close now hangs.
The attached patch changes test_event.py to not skip test_subprocess_* but now
skips
Guido van Rossum added the comment:
I think I know what that is -- the test should use a socketpair now. I'll see
how quickly I can give you a patch for that. The other one is now committed.
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
David, try this fix (aixfix.diff).
--
Added file: http://bugs.python.org/file32291/aixfix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
David Edelsohn added the comment:
test_asyncio no longer hangs on AIX with the aixfix.diff patch. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Corrected aixfix.diff (the other one was for the Tulip repo).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Changes by Guido van Rossum gu...@python.org:
--
Removed message: http://bugs.python.org/msg200877
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Corrected aixfix.diff for CPython repo (the previous one was for the Tulip
repo).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Third try's a charm. Corrected aix fix.
--
Added file: http://bugs.python.org/file32292/aixfix2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
Changes by Guido van Rossum gu...@python.org:
--
Removed message: http://bugs.python.org/msg200878
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Changes by Guido van Rossum gu...@python.org:
Removed file: http://bugs.python.org/file32291/aixfix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Roundup Robot added the comment:
New changeset c2e018c54689 by Guido van Rossum in branch 'default':
Fix asyncio issue #19293 (hangs on AIX).
http://hg.python.org/cpython/rev/c2e018c54689
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
And there was much rejoicing.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
David Edelsohn added the comment:
You have to try harder to break it again. aixfix2.diff still works. ;-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
26 matches
Mail list logo
