[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-21 Thread STINNER Victor
STINNER Victor added the comment: Thanks. "(most recent call first)" was already present in some cases, but I forgot to mention it in all cases. -- ___ Python tracker ___ __

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-20 Thread Guido van Rossum
Guido van Rossum added the comment: On Victor's authority, committed. I've also (separately) committed some doc changes. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset cc8c37b5b449 by Guido van Rossum in branch 'default': Issue 19306: Add extra hints to faulthandler stack dumps that they are upside down. http://hg.python.org/cpython/rev/cc8c37b5b449 -- nosy: +python-dev __

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-20 Thread STINNER Victor
STINNER Victor added the comment: > TBH now I'm getting worried that other programs may exist that parse this > format and will get confused. A program parsing faulthandler output? Seriously? It would be nice, but I don't know any. Anyway, such program would probably use a regex to parse the

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-20 Thread Guido van Rossum
Guido van Rossum added the comment: New patch, with fixed test. TBH now I'm getting worried that other programs may exist that parse this format and will get confused. -- Added file: http://bugs.python.org/file32267/traceback2.diff ___ Python tracke

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-20 Thread STINNER Victor
STINNER Victor added the comment: You must update unit tests in test_faulthandler. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-19 Thread Guido van Rossum
Guido van Rossum added the comment: BTW, another oddity in traceback.c: dump_hexadecimal() has the "int fd" argument at the end, while all other dump_*() functions have it at the front -- even its cousin dump_decimal(). Here's a patch that includes a fix. -- keywords: +patch Added file

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: pitrou -> haypo nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue19306] Warn unsuspecting readers that thread stacks are in reverse order

2013-10-19 Thread Guido van Rossum
New submission from Guido van Rossum: I was confused for a while when seeing the thread stacks dumped by the faulthandler module. (See issue 19293.) I propose the following tweaks of the output to make this more obvious. The first chunk changes the header written when called as _Py_DumpTraceb