[issue19316] devguide: compiler - wording

Ezio Melotti added the comment: Fixed, thanks everyone for the patches and the reviews! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue19316] devguide: compiler - wording

Roundup Robot added the comment: New changeset 43d842419188 by Ezio Melotti in branch 'default': #19316: fix wording in the compiler.rst page. https://hg.python.org/devguide/rev/43d842419188 -- nosy: +python-dev ___ Python tracker

[issue19316] devguide: compiler - wording

Stéphane Wirtel added the comment: maybe :/ I have reinstalled my laptop, will try to find the patch asap -- ___ Python tracker ___ _

[issue19316] devguide: compiler - wording

Elena Oat added the comment: Here's the patch regenerated for the latest devguide. -- nosy: +Elena.Oat Added file: http://bugs.python.org/file41568/issue19316.diff ___ Python tracker ___

[issue19316] devguide: compiler - wording

Ezio Melotti added the comment: Stéphane, did you forget to attach the patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue19316] devguide: compiler - wording

Stéphane Wirtel added the comment: Hi everybody, Here is a new version of the script for the last version of the devguide. 198554fa82c2 Please review and apply. -- nosy: +matrixise ___ Python tracker

[issue19316] devguide: compiler - wording

Carol Willing added the comment: I've reviewed doc19316.patch. Unfortunately, the patch does not apply cleanly to the up-to-date codebase; it emits this error: ``` patching file compiler.rst Hunk #1 succeeded at 41 with fuzz 2. Hunk #3 succeeded at 175 (offset 6 lines). patch: malformed pa

[issue19316] devguide: compiler - wording

Terry J. Reedy added the comment: I will try to take a look, but anyone else is welcome to also. -- ___ Python tracker ___ ___ Python-

[issue19316] devguide: compiler - wording

Nitika Agarwal added the comment: Hi, anyone please review my patch attached. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue19316] devguide: compiler - wording

Nitika Agarwal added the comment: Hi, I have attached the patch.Please review the patch attached. -- ___ Python tracker ___ ___ Python

[issue19316] devguide: compiler - wording

Nitika Agarwal added the comment: -This document does not touch on how parsing works beyond what is needed to explain what is needed for compilation. It is also not exhaustive in terms of the how the entire system works. You will most likely need to read some source to have an exact understand

[issue19316] devguide: compiler - wording

Éric Araujo added the comment: The task here is to work from Ezio’s patch* and edit it to take into account Terry’s replies and your own opinions about what wording is best. * http://docs.python.org/devguide/faq.html#how-do-i-apply-a-patch -- ___ Py

[issue19316] devguide: compiler - wording

Nitika Agarwal added the comment: I am able to find some errors in the link i just gave in the previous message, so should i submit a patch highlighting those errors ? -- ___ Python tracker ___

[issue19316] devguide: compiler - wording

Éric Araujo added the comment: Yes, it’s that file. The source is compiler.rst in this repository: http://hg.python.org/devguide -- nosy: +eric.araujo ___ Python tracker ___ __

[issue19316] devguide: compiler - wording

Nitika Agarwal added the comment: Hi, http://docs.python.org/devguide/compiler.html Is this the link of the devguide that needs to be updated? -- nosy: +nitika ___ Python tracker ___

[issue19316] devguide: compiler - wording

Terry J. Reedy added the comment: Proposes changes could have been put in one (or just a few) messages with numbered suggestions. This would make it easier to refer to them. Each could have had a link to the file involved in order to make it easy to look at context. My opinions: msg200572 di

[issue19316] devguide: compiler - wording

Berker Peksag added the comment: > - import.c > - Home of the magic number (named MAGIC) for bytecode versioning > > Probably out of date. I cannot find MAGIC being defined in this file. It's in importlib._bootstrap: http://hg.python.org/cpython/file/5dc65f8d29a2/Lib/importlib/_bootstrap.py#l37

[issue19316] devguide: compiler - wording

Ezio Melotti added the comment: Here is a single diff that combines all these patches and a few more things from #19315. -- assignee: -> ezio.melotti stage: -> patch review type: -> enhancement Added file: http://bugs.python.org/file32270/issue19316.diff

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - Lib/ - compiler/ - pyassem.py - One of the files that must be modified if Include/opcode.h is changed. - pycodegen.py - One of the files that must be modified if Include/opcode.h is changed. More mentions of the compiler package. -- Added file: http:

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - import.c - Home of the magic number (named MAGIC) for bytecode versioning Probably out of date. I cannot find MAGIC being defined in this file. -- ___ Python tracker _

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - marshaling marshalling -- Added file: http://bugs.python.org/file32251/wording_typo.diff ___ Python tracker ___

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - If you wish to make changes that affect the output of bytecode without having to update the magic number each time (while testing your changes) you can just delete your old .py(c|o) files! Even though you will end up changing the magic number if you change

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - But you will also need to change the ‘compiler’ package. The key files to do that are Lib/compiler/pyassem.py and Lib/compiler/pycodegen.py . "compiler" was removed in 2.6 or 2.7 iirc. I think it's safe to remove these two sentences. -- Added file:

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - As for handling the line number on which a statement is defined, is handled by compiler_visit_stmt() and thus is not a worry. I don't understand the final clause here. What is not a worry and why would it be a worry? The grammar is awkward as well. --

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - Function and macros for creating and using asdl_seq * types as found in Python/asdl.c and Include/asdl.h: I propose: The following are functions and macros for creating and using asdl_seq * types as found in Python/asdl.c and Include/asdl.h: -- Add

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - The functions called to generate AST nodes from the parse tree all have the name ast_for_xx where xx is what the grammar rule that the function handles (alias_for_import_name is the exception to this). I'm not sure if this ought to be "where xx is the gram

[issue19316] devguide: compiler - wording

Martin Matusiak added the comment: - This needs to only be called in strategic areas where the compiler exits. I propose: This only needs to be called in strategic areas where the compiler exits. -- Added file: http://bugs.python.org/file32247/wording_compiler2.diff __

[issue19316] devguide: compiler - wording

New submission from Martin Matusiak: - All code relating to the arena is in either Include/pyarena.h or Python/pyarena.c . I propose: All code relating to the arena is either in Include/pyarena.h or in Python/pyarena.c . -- components: Devguide files: wording_compiler.diff keywords: