[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset ea3deb022890 by Victor Stinner in branch '3.3': Close #19339: telnetlib module is now using time.monotonic() when available to http://hg.python.org/cpython/rev/ea3deb022890 New changeset d0f90d3f6203 by Victor Stinner in branch 'default': (Merge

[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-26 Thread STINNER Victor
STINNER Victor added the comment: Victor, did you see Serhiy's comment? Yes, I modified my patch to use _time name instead. The issue should now be fixed. -- stage: committed/rejected - ___ Python tracker rep...@bugs.python.org

[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-25 Thread Charles-François Natali
Charles-François Natali added the comment: Victor, did you see Serhiy's comment? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19339 ___ ___

[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-21 Thread STINNER Victor
New submission from STINNER Victor: While reading the patch attached to #19170, I saw that telnetlib uses time.time() to compute a timeout. This is wrong: the system clock may jump forward or backward (ex: summer/winter time, NTP adjust, manual clock change by the administrator, etc.).

[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-21 Thread Charles-François Natali
Charles-François Natali added the comment: You can go ahead! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19339 ___ ___ Python-bugs-list

[issue19339] telnetlib: time.monotonic() should be used instead of time.time() for timeout

2013-10-21 Thread STINNER Victor
STINNER Victor added the comment: Patch for telnetlib of Python 3.3. -- keywords: +patch Added file: http://bugs.python.org/file32288/telnetlib_monotonic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19339