Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +brian.curtin, tim.golden
versions: +Python 2.7, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19356
___
Tim Golden added the comment:
I don't feel strongly about this. However, ISTM that we work reasonably
hard to work with the vagaries of *nix toolchains so I don't see why an
unintrusive change like this shouldn't go in to support some corner
cases on the Windows front.
--
Antoine Pitrou added the comment:
I see other instances of _self in elementtree and ctypes. Don't you want to
replace those too?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19356
Jeffrey Armstrong added the comment:
That was sloppy of me to not check other modules. I hadn't encountered them in
my build yet. Here's a patch for Modules/_ctypes/_ctypes.c and
Modules/_ctypes/callbacks.c. The arguments were changed similarly to myself.
--
Added file:
Jeffrey Armstrong added the comment:
And finally here's the necessary changes to Modules/_elementree.c as well.
--
Added file: http://bugs.python.org/file32312/_elementree._self.3.3.2.patch
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Thanks for the patches, they're committed now.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 763af3d957f3 by Antoine Pitrou in branch '3.3':
Issue #19356: Avoid using a C variabled named _self, it's a reserved word in
some C compilers.
http://hg.python.org/cpython/rev/763af3d957f3
New changeset f6430aec5bf2 by Antoine Pitrou in branch
New submission from Jeffrey Armstrong:
At Modules/_io/textio.c:285, one argument to
_PyIncrementalNewlineDecoder_decode is named _self. The name _self,
however is a keyword on older Microsoft C compilers and certain other compilers
attempting to maintain compatibility with Microsoft.
Changes by Jeffrey Armstrong jeffrey.armstr...@approximatrix.com:
--
type: - compile error
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19356
___
