[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: I closed the issue because we decided to not document the function, but I'm still interested to mark the API is private. Such change is more sensitive, so I added it my larger "New C API" project which works on finding a way to deprecate functions and provid

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Change by STINNER Victor : -- resolution: out of date -> wont fix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: It seems like these functions should be documented, so I close the issue. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker __

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

João Sebastião de Oliveira Bueno added the comment: This discussion is fresh, so maybe it is worth asking here prior to python-ideas: In Python we can change any global variable, object attribute or mapping-value with function calls. Locals and nonlocals are the only exceptions and from time

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: > Currently you should call PyFrame_FastToLocalsWithError(), modify directly > f_locals, and call PyFrame_LocalsToFast(). When happens if PyFrame_LocalsToFast() isn't called? Does it crash or is it just slower? -- ___

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Serhiy Storchaka added the comment: frameobject.h is not included in any header file. Some effort was spent for avoiding including it in ceval.h, genobject.h, pystate.h and traceback.h. The whole content of frameobject.h is not available in the limited API. I'm not sure about the status of th

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: Serhiy: how are you supposed to modify local variables of a frame when these variables are stored in "fast locals"? Even if it's a rare useful, I think that it's ok to expose PyFrame_FastToLocalsWithError(), and maybe also PyFrame_FastToLocals(). It is usefu

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: > If I only convert PyFrame_New() then I would need to add it to as existing > page since the patch created a new page for Frame Objects. I think the right > place would be under the current PyFrameObject in Doc/c-api/veryhigh.rst? Not, it's a very high leve

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Cheryl Sabella added the comment: Thanks Victor and Serhiy. >> @Cheryl: Maybe convert the PR without PyFrame_FastToLocals() and >> PyFrame_FastToLocalsWithError(). If I only convert PyFrame_New() then I would need to add it to as existing page since the patch created a new page for Frame Obj

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: Ah, PyFrame_GetLineNumber is now documented at Doc/c-api/reflection.rst. But PyFrame_New() is still not documented. So my patch is not completely useful. @Cheryl: Maybe convert the PR without PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError(). --

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: > PyFrame_FastToLocals() and PyFrame_LocalsToFast() are not documented and have > weird interface. I think the use of them should be discouraged. I suggest to document them, but explain in the documentation that they must not be used :-) --

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: > Should there be a PR for this? Feel free to create a PR from my old (4 years old) patch. Just mention my name in the commit message please. -- ___ Python tracker

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Serhiy Storchaka added the comment: PyFrameObject already is documented in Doc/c-api/veryhigh.rst. PyFrame_GetLineNumber() already is documented in Doc/c-api/reflection.rst. PyFrame_FastToLocals() and PyFrame_LocalsToFast() are not documented and have weird interface. I think the use of them sh

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

Cheryl Sabella added the comment: Victor, Should there be a PR for this? -- nosy: +csabella ___ Python tracker ___ ___ Python-bugs-li

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

STINNER Victor added the comment: c_api_frame.patch: document some C functions of the frame object in the C API. -- keywords: +patch Added file: http://bugs.python.org/file32537/c_api_frame.patch ___ Python tracker

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

New submission from STINNER Victor: (Copy of an email) Georg Brandl via python.org Am 29.10.2013 01:19, schrieb victor.stinner: > http://hg.python.org/cpython/rev/4ef4578db38a > changeset: 86715:4ef4578db38a > user:Victor Stinner > date:Tue Oct 29 01:19:37 2013 +0100