[issue19546] configparser leaks implementation detail

Claudiu Popa added the comment: No problem, thank you for committing it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19546] configparser leaks implementation detail

Łukasz Langa added the comment: Thank you Claudiu for your patch, sorry it took so long to respond. -- ___ Python tracker ___ ___ Pyth

[issue19546] configparser leaks implementation detail

Changes by Łukasz Langa : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue19546] configparser leaks implementation detail

Roundup Robot added the comment: New changeset 2b14665b7bce by Łukasz Langa in branch 'default': Fix #19546: onfigparser exceptions expose implementation details. Patch by Claudiu Popa. http://hg.python.org/cpython/rev/2b14665b7bce New changeset 554ead559f24 by Łukasz Langa in branch 'default'

[issue19546] configparser leaks implementation detail

Claudiu Popa added the comment: Łukasz, do you have some time to take a look at this patch? -- type: -> behavior versions: +Python 3.5 Added file: http://bugs.python.org/file35791/issue19546_1.patch ___ Python tracker

[issue19546] configparser leaks implementation detail

Claudiu.Popa added the comment: If there is anything left to do for this patch, please tell me. -- Added file: http://bugs.python.org/file34837/issue19546.patch ___ Python tracker __

[issue19546] configparser leaks implementation detail

Łukasz Langa added the comment: FWIW I agree with Claudiu that the internal exceptions are an implementation detail. If we ever made, say, a SQLite-based or memcache-based configparser, those would be different, but the external API would stay the same. Will fix. -- _

[issue19546] configparser leaks implementation detail

R. David Murray added the comment: I've been thinking about this more, and I think I will revise my opinion. I haven't been able to think of a place where knowing that the key is missing in self._sections would in fact be helpful to a programmer using the module. So I'm OK with this being an

[issue19546] configparser leaks implementation detail

Claudiu.Popa added the comment: Ups, sorry for the change of resolution. -- resolution: 3rd party -> ___ Python tracker ___ ___ Pytho

[issue19546] configparser leaks implementation detail

Claudiu.Popa added the comment: I've created a new issue for the InterpolationMissingOptionError message, issue21159. This issue can be closed. -- resolution: -> 3rd party ___ Python tracker _

[issue19546] configparser leaks implementation detail

R. David Murray added the comment: Although I will grant you that I have to guess at what the bad value substitution error message is trying to tell me, so that error message could use some improvement. -- ___ Python tracker

[issue19546] configparser leaks implementation detail

R. David Murray added the comment: Why? Just let the context convey the information. It's not like we are building a UI here, this is for the programmer. -- ___ Python tracker ___

[issue19546] configparser leaks implementation detail

Claudiu.Popa added the comment: But the last traceback conveys enough information, the user can see immediately that the given section does not exist. My problem with the current behaviour is that the first error distracts the user, while the actual problem is the second traceback. But I have a

[issue19546] configparser leaks implementation detail

Changes by Łukasz Langa : -- assignee: -> lukasz.langa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19546] configparser leaks implementation detail

R. David Murray added the comment: I'd vote -1 on this one. The extra context in this case is not confusing, and might be helpful to someone. -- nosy: +r.david.murray ___ Python tracker __

[issue19546] configparser leaks implementation detail

New submission from Claudiu.Popa: Various exceptions raised by configparser module leaks implementation detail, by chaining KeyErrors, as seen below: Python 3.4.0a4+ (default:0aa2aedc6a21+, Nov 5 2013, 17:10:42) [GCC 4.2.1 20070831 patched [FreeBSD]] on freebsd8 Type "help", "copyright", "cred