STINNER Victor added the comment:
I think the issue has been fixed, thanks.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19566
___
STINNER Victor added the comment:
Also reproduced on x86 Ubuntu Shared 3.x buildbot.
http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/9012/steps/test/logs/stdio
==
ERROR: test_close
STINNER Victor added the comment:
Attached patch should fix this issue. BaseChildWatcher constructors calls
set_loop() which calls _do_waitpid_all(). The problem is that _do_waitpid_all()
is called before FastChildWatcher own attributes are set.
--
keywords: +patch
Added file:
Guido van Rossum added the comment:
Hmm... That fix works, and if you're concerned about the buildbots, by all
means check it in.
But I think the root cause is a poor API for initializing ChildWatchers. This
is currently done at the end of __init__() -- it calls self.set_loop() which is
Anthony Baire added the comment:
I confirm the fix.
It is clear that the separation between BaseChildWatcher and its subclasses is
far from ideal. The first implementation was clean, but as the patch evolved
interactions got complex to the point that BaseChildWatcher should not be
considered
Guido van Rossum added the comment:
TBH the test structure is also rather fragile. I need to think about it more;
the global state to hold the current test instance smells, as do the various
class-level functions (waitpid(), WIFEXITED() etc.) that aren't methods but
used as mock functions.
Guido van Rossum added the comment:
I pushed Victor's temporary patch so the buildbots can have peace.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19566
___
Roundup Robot added the comment:
New changeset 8e0eeb4cc8fa by Guido van Rossum in branch 'default':
asyncio: Temporary fix by Victor Stinner for issue 19566.
http://hg.python.org/cpython/rev/8e0eeb4cc8fa
--
nosy: +python-dev
___
Python tracker
Anthony Baire added the comment:
I put a cleaner patch here:
https://codereview.appspot.com/26220043/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19566
___
STINNER Victor added the comment:
Hmm... That fix works, and if you're concerned about the buildbots, by all
means check it in.
(...)
I pushed Victor's temporary patch so the buildbots can have peace.
Yes, I'm concerned by buildbots, I would like to check if my last
changes did not
STINNER Victor added the comment:
(So thanks for having applied my fix.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19566
___
___
Roundup Robot added the comment:
New changeset eb42adc53923 by Guido van Rossum in branch 'default':
asyncio: Fix from Anthony Baire for CPython issue 19566 (replaces earlier fix).
http://hg.python.org/cpython/rev/eb42adc53923
--
___
Python tracker
New submission from STINNER Victor:
The following test of test_asyncio failed once. I didn't check if it failed
more than once on this buildbot.
The cleanup code is not safe, it should handle errors correctly, so following
tests would not fail.
Guido van Rossum added the comment:
I'll ask Anthony Baire (the author of the new child watcher code) to look into
this. Thanks for reporting this!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19566
14 matches
Mail list logo
