[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-08-22 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-08-22 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, Claudiu. Sorry it took so long to apply, but you know what I have been working on instead so I'm sure you understand. =) -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-08-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset a21ddb1c41d2 by Brett Cannon in branch 'default': Issue #19714: Tests for importlib.machinery.WindowsRegistryFinder. http://hg.python.org/cpython/rev/a21ddb1c41d2 -- nosy: +python-dev ___ Python tracker

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-08-13 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-07-07 Thread Martin v . Löwis
Martin v. Löwis added the comment: The patch looks fine to me. Someone please apply. -- stage: patch review -> commit review ___ Python tracker ___ __

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-07-05 Thread Brett Cannon
Brett Cannon added the comment: I can do the review if no Windows people step forward. -- ___ Python tracker ___ ___ Python-bugs-list

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-07-04 Thread Mark Lawrence
Mark Lawrence added the comment: Latest patch LGTM at a quick glance. Can we have a patch review please as #18864 is dependent on this. -- nosy: +BreamoreBoy ___ Python tracker ___

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-06-15 Thread Claudiu Popa
Claudiu Popa added the comment: Attached a new version of the patch. The previous one called find_spec twice in the same test. -- Added file: http://bugs.python.org/file35651/issue19714_2.patch ___ Python tracker

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-06-15 Thread Claudiu Popa
Changes by Claudiu Popa : -- stage: test needed -> patch review versions: +Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mail

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-04-23 Thread Jim Jewett
Jim Jewett added the comment: Pinging Martin ... earlier comments seem to have been completed. -- nosy: +Jim.Jewett ___ Python tracker ___ ___

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-28 Thread Eric Snow
Eric Snow added the comment: Martin: are you okay with Claudiu's latest patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-22 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34570/issue19714.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-21 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34553/issue19714.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. Here's a patch for this issue. It tests only the conditions described by Eric. -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.org/file34549/issue19714.patch ___ Python tracker

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-01-02 Thread Eric Snow
Eric Snow added the comment: I added 2 rudimentary tests for issue #20097 which gives at least coverage in the test suite, but we need the following tests still: * registry entry exists and module is found (spec returned) * registry entry exists and module is not found (None returned) Dependin

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2013-12-31 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +vajrasky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2013-12-11 Thread Eric Snow
Changes by Eric Snow : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2013-11-23 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2013-11-22 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +eric.snow, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2013-11-22 Thread Brett Cannon
New submission from Brett Cannon: At least mocking out things if manipulating the Windows registry during testing is considered bad or difficult to make sure that stuff basically works. -- components: Library (Lib) messages: 203809 nosy: brett.cannon priority: normal severity: normal st