Rhonda Parker added the comment:
T0 the people that manipulate universe of linux and unix based protocol should
take in consideration when people skilled programming introduce downloads and
install protocol to those unskilled in the like because it only creates a
disassociation resulting in
Changes by Alexandre Vassalotti alexan...@peadrop.com:
--
Removed message: http://bugs.python.org/msg204785
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
___
Antoine Pitrou added the comment:
Well, it *is* abstract because it has no implementations and all the
methods raise NotImplementedError.
Hmm, actually, the methods don't raise NotImplementedError, they just have
default empty implementations.
--
Guido van Rossum added the comment:
You're right, I commented previously without reading the context. The classes
defined in protocol.py are not ABCs, they are just base classes (and not
mandatory, just convenient, because the transport *will* assume all methods are
implemented, and call
Changes by Guido van Rossum gu...@python.org:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
___
Roundup Robot added the comment:
New changeset 5469e1a68dbd by Guido van Rossum in branch 'default':
asyncio: Use Interface instead of ABC. Fixes issue 19726.
http://hg.python.org/cpython/rev/5469e1a68dbd
--
___
Python tracker rep...@bugs.python.org
Changes by Nick Coghlan ncogh...@gmail.com:
--
Removed message: http://bugs.python.org/msg204783
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
versions: +Python 3.4 -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
___
Roundup Robot added the comment:
New changeset 04088790c077 by Nick Coghlan in branch 'default':
Issue #19726: actually running 'hg add' helps...
http://hg.python.org/cpython/rev/04088790c077
--
nosy: +python-dev
___
Python tracker
Antoine Pitrou added the comment:
I don't think it's necessary either. They don't *need* to be ABCs, but if they
aren't the docstring should be fixed :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
Guido van Rossum added the comment:
I'm not sure that ABC implies an instance of abc.ABC. It's still an
abstract base class (in the usual definition of that concept) even if it
doesn't enforce anything.
I propose to close this as wontfix.
--
___
Antoine Pitrou added the comment:
Well, IMHO it's better spelt base class if it isn't technically an ABC. At
least I was personally a bit surprised at first.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19726
Guido van Rossum added the comment:
Well, it *is* abstract because it has no implementations and all the
methods raise NotImplementedError. We can do better in the .rst docs though.
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Well, it *is* abstract because it has no implementations and all the
methods raise NotImplementedError. We can do better in the .rst docs though.
I didn't know what to do with it, so I didn't mention it at all in
the .rst docs :-)
--
New submission from Antoine Pitrou:
BaseProtocol docstring describes it as an ABC for base protocol class, but it
is not actually an ABC in the technical sense.
--
assignee: gvanrossum
components: Library (Lib)
messages: 203921
nosy: gvanrossum, pitrou
priority: normal
severity: normal
Guido van Rossum added the comment:
Good question. I don't mind making these ABCs, but I don't think it's necessary
to do it before beta1 (since it won't matter for most people).
--
___
Python tracker rep...@bugs.python.org
16 matches
Mail list logo