[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-25 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: Thanks Zachary for the notice! Look like my change fixed the warnings on the Windows x86 build. http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1801 -- resolution: -> fixed status: open -> closed __

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset f8ac01a762c1 by Alexandre Vassalotti in branch 'default': Issue #19739: Try to fix compiler warnings on 32-bit Windows. http://hg.python.org/cpython/rev/f8ac01a762c1 -- nosy: +python-dev ___ Python tracke

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-25 Thread Zachary Ware
Zachary Ware added the comment: The attached patch fixes the warnings and doesn't appear to break anything obvious. The first 4 are fixed by reverting Alexandre's change from '#if SIZEOF_SIZE_T' to 'if (sizeof(size_t)'. The last one is different from the original 5th warning, and is fixed usi

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-25 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-25 Thread Zachary Ware
Zachary Ware added the comment: This appears to be back with slightly different line numbers: ..\Modules\_pickle.c(718): warning C4293: '>>' : shift count negative or too big, undefined behavior ..\Modules\_pickle.c(719): warning C4293: '>>' : shift count negative or too big, undefined behavio

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've fixed the first 4 in 458340ed0606 and the signed/unsigned warning in c3fd79b17983. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Yes, there is actually a bug which shows up as errors in the tests. I'm currently testing a patch for it. -- ___ Python tracker ___ ___

[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

2013-11-23 Thread Tim Peters
New submission from Tim Peters: 1>..\Modules\_pickle.c(710): warning C4293: '>>' : shift count negative or too big, undefined behavior 1>..\Modules\_pickle.c(711): warning C4293: '>>' : shift count negative or too big, undefined behavior 1>..\Modules\_pickle.c(712): warning C4293: '>>' : shift