[issue19748] test_time failures on AIX

STINNER Victor added the comment: I'm no more interested to work on this issue, I prefer to close it. -- resolution: -> out of date status: open -> closed ___ Python tracker ___

[issue19748] test_time failures on AIX

STINNER Victor added the comment: >>> time.mktime(time.localtime(-1)) Traceback (most recent call last): File "", line 1, in OverflowError: mktime argument out of range Oh yes, I now remember it. Sorry, it was 3 years ago: http://bugs.python.org/issue11188#msg128541 The problem is to detect

[issue19748] test_time failures on AIX

Roundup Robot added the comment: New changeset 00e94e454813 by Victor Stinner in branch 'default': Issue #11188, #19748: mktime() returns -1 on error. On Linux, the tm_wday field http://hg.python.org/cpython/rev/00e94e454813 -- ___ Python tracker

[issue19748] test_time failures on AIX

David Edelsohn added the comment: >>> time.localtime(-2) time.struct_time(tm_year=1969, tm_mon=12, tm_mday=31, tm_hour=15, tm_min=59, tm_sec=58, tm_wday=2, tm_yday=365, tm_isdst=0) >>> time.localtime(-1) time.struct_time(tm_year=1969, tm_mon=12, tm_mday=31, tm_hour=15, tm_min=59, tm_sec=59, tm_

[issue19748] test_time failures on AIX

STINNER Victor added the comment: """ WITHOUT the patch to timemodule.c: >>> time.ctime(-2**29) 'Fri Dec 26 21:11:28 1952' """ Oh, in this case, pylocaltime_aix.patch is wrong. There was a bug in mktime(), but ctime() works fine. """ File "/home/dje/src/cpython/Lib/test/test_time.py", line

[issue19748] test_time failures on AIX

David Edelsohn added the comment: WITH the patch: >>> time.ctime(-2**29) Traceback (most recent call last): File "", line 1, in OverflowError: ctime() timestamp argument out of range >>> time.ctime(2**29) 'Mon Jan 5 10:48:32 1987' OK (skipped=8) 1 test OK. -- _

[issue19748] test_time failures on AIX

David Edelsohn added the comment: WITHOUT the patch to timemodule.c: >>> time.ctime(-2**29) 'Fri Dec 26 21:11:28 1952' >>> time.ctime(2**29) 'Mon Jan 5 10:48:32 1987' ERROR: test_mktime (test.test_time.TimeTestCase) -- Traceba

[issue19748] test_time failures on AIX

STINNER Victor added the comment: > With the latest patch, test_time passes. Ok, thanks for your tests. But time.ctime() is still wrong. Can you please try the following examples with the latest Python version (502c8b7e8ad2) and then retry with pylocaltime_aix.patch? >>> time.ctime(-2**29) 'S

[issue19748] test_time failures on AIX

Roundup Robot added the comment: New changeset 502c8b7e8ad2 by Victor Stinner in branch 'default': Issue #19748: On AIX, time.mktime() now raises an OverflowError for year http://hg.python.org/cpython/rev/502c8b7e8ad2 -- nosy: +python-dev ___ Python t

[issue19748] test_time failures on AIX

David Edelsohn added the comment: With the latest patch, test_time passes. >>> time.mktime((-100, 1, 10) + (0,)*6) Traceback (most recent call last): File "", line 1, in OverflowError: mktime argument out of range >>> time.mktime((-100, 1, 10) + (0,)*6) Traceback (most recent call last): Fi

[issue19748] test_time failures on AIX

STINNER Victor added the comment: @David Edelsohn: Oh nice, mktime() has an integer overflow on AIX. Could you please try to apply attached mktime_aix.patch, run test_time and try again my examples of msg211616? Thanks. -- Added file: http://bugs.python.org/file34153/mktime_aix.patch

[issue19748] test_time failures on AIX

David Edelsohn added the comment: >>> time.mktime((-100, 1, 10) + (0,)*6) -897577382.0 >>> time.mktime((100, 1, 10) + (0,)*6) 111922.0 >>> time.mktime((1900, 1, 10) + (0,)*6) 2086784896.0 >>> time.mktime((1930, 1, 10) + (0,)*6) -1261497600.0 >>> time.mktime((1969,12,31, 23,59,59, 0,0,0)) 2879

[issue19748] test_time failures on AIX

STINNER Victor added the comment: > which is what I would expect based on the patch and the new AIX-specific > error message. What did you expect? No, mktime() and ctime() should both raise OverflowError. It looks like mktime() doesn't fail. Can you please try the following examples on AIX? E

[issue19748] test_time failures on AIX

David Edelsohn added the comment: With the patch, the results are: ERROR: test_ctime (test.test_time.TimeTestCase) -- Traceback (most recent call last): File "/home/dje/src/cpython/Lib/test/test_time.py", line 239, in test_cti

[issue19748] test_time failures on AIX

Serhiy Storchaka added the comment: Isn't this a duplicate of issue11188? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python

[issue19748] test_time failures on AIX

STINNER Victor added the comment: @David Edelsohn: Can you please test attached patch on AIX? It should fix test_mktime and test_ctime. -- keywords: +patch Added file: http://bugs.python.org/file34130/pylocaltime_aix.patch ___ Python tracker

[issue19748] test_time failures on AIX

David Edelsohn added the comment: The valid range is 00:00:00 UTC, January 1, 1970 to 03:14:07 UTC, January 19, 2038. -- ___ Python tracker ___ _

[issue19748] test_time failures on AIX

STINNER Victor added the comment: @David: Can you try to check what the minimum accepted timestamp for the time module? -- ___ Python tracker ___ ___

[issue19748] test_time failures on AIX

STINNER Victor added the comment: Oh, I missed also this one: == FAIL: test_mktime_error (test.test_time.TimeTestCase) -- Traceback (most recent call last):

[issue19748] test_time failures on AIX

New submission from STINNER Victor: http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/1138/steps/test/logs/stdio == ERROR: test_mktime (test.test_time.TimeTestCase)