[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Roundup Robot added the comment: New changeset 7ce56727edc7 by Georg Brandl in branch '3.2': ref #19855: skip uuid test_find_mac on non-Posix as in later branches https://hg.python.org/cpython/rev/7ce56727edc7 -- ___ Python tracker

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Changes by Georg Brandl : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Georg Brandl added the comment: I see test failures on Windows: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20custom/builds/62/steps/test/logs/stdio http://buildbot.python.org/all/builders/x86%20Windows7%20custom/builds/52/steps/test/logs/stdio Do the tests need changing too

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Roundup Robot added the comment: New changeset f9cd915410d2 by Georg Brandl in branch '3.2': Issue #19855: uuid.getnode() on Unix now looks on the PATH for the https://hg.python.org/cpython/rev/f9cd915410d2 -- ___ Python tracker

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Georg Brandl added the comment: Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Serhiy Storchaka added the comment: There was other bug fixes not applied to 3.2. Here is cumulated patch for issue16102, issue18784, issue11508, and issue19855. They have same severity as this issue. There is also issue22131 (not applied to 3.3) and issue9678 (in progress). -- Added

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Georg Brandl added the comment: Serhiy, would you make a patch for 3.2 too? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-b

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Roundup Robot added the comment: New changeset 9fe32328a573 by R David Murray in branch '2.7': #19855: restore use of LC_ALL, not LC_MESSAGES http://hg.python.org/cpython/rev/9fe32328a573 New changeset 706354c4d8f5 by R David Murray in branch '3.3': #19855: restore use of LC_ALL, not LC_MESSAGES

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Arfrever Frehtes Taifersar Arahesis added the comment: When LC_ALL is already set in environment, LC_MESSAGES will not override it. I suggest to restore LC_ALL=C in place of LC_MESSAGES=C. -- ___ Python tracker ___

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

R. David Murray added the comment: I'm on gentoo, so this was causing test runs to fail for me, giving me sufficient motivation to review the patches and commit them :) Thanks, Serhiy. -- nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status: open

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Roundup Robot added the comment: New changeset b0fbaed45956 by R David Murray in branch '3.3': #19855: uuid.get_node now looks on the PATH for executables on unix. http://hg.python.org/cpython/rev/b0fbaed45956 New changeset 2e856fcb9084 by R David Murray in branch 'default': Merge: #19855: uuid.

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Serhiy Storchaka added the comment: And here is a patch for 2.7. It uses backported from 3.3 and simplified variant of shutil.which(). -- Added file: http://bugs.python.org/file33152/uuid_find_mac_which-2.7.patch ___ Python tracker

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Serhiy Storchaka added the comment: This check was added in r50954 (changeset 654c380cf8b9). Here is better (but larger) patch for 3.3+. -- assignee: -> serhiy.storchaka nosy: +nnorwitz Added file: http://bugs.python.org/file33151/uuid_find_mac_which_2.patch __

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

Serhiy Storchaka added the comment: Initially the issue was reported in msg204881. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin

New submission from Serhiy Storchaka: The uuid._find_mac() function tests that executable file exist before run it. First it tries to run unmodified executable name (i.e. from $PATH) and then from the /sbin or /usr/sbin directories. However test for unmodified executable name is wrong, actuall