Roundup Robot added the comment:
New changeset a5895fca91f3 by Serhiy Storchaka in branch '3.3':
Issue #19920: TarFile.list() no longer fails when outputs a listing
http://hg.python.org/cpython/rev/a5895fca91f3
New changeset 077aa6d4f3b7 by Serhiy Storchaka in branch 'default':
Issue #19920:
Serhiy Storchaka added the comment:
Thank you for your patch Vajrasky.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19920
Serhiy Storchaka added the comment:
Well, good.
But I still have several nitpicks. Here is revised patch.
* Now ASCII encoding is used to test list() output. And tests now run even if
sys.stdout is a StringIO.
* test_list_verbose now test that printed files are actually separated by one
new
Vajrasky Kok added the comment:
Here is the patch to accommodate Serhiy's request. I added new test soutside
CommandLineTest. The fix always uses sys.stdout.encoding. The test_list_command
and test_list_command_verbose uses testtarnames now.
--
Added file:
Vajrasky Kok added the comment:
I already have a patch addressing your concerns, Serhiy. But before I upload it
here, some questions:
1. Yes, we can add unencodable tarinfo.linkname later. Just add tests for
external tar files. You mean, we need to create a tar file containing
unencodable
Serhiy Storchaka added the comment:
1. No. Just use existing nonmodified testtar.tar now. Later we will add new
items in it.
2. The encoding of sys.stdout is not always the same as default locale
encoding. You can redirect sys.stdout to text file (opened with different
encoding) or to socket
Serhiy Storchaka added the comment:
I have added new portion of nitpicks on Rietveld.
For you questions:
1. Yes, we can add unencodable tarinfo.linkname later. Just add tests for
external tar files.
2. Use support.captured_stdout() (see test_list_command_verbose).
--
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19920
___
___
Vajrasky Kok added the comment:
Here is the patch addressing some of Serhiys concerns. Thanks for the review.
There are some things that I could not make it up:
1. The test for unencodable tarinfo.linkname is not done yet, because maybe it
is better to be done in a separate ticket. To make the
Changes by Vajrasky Kok sky@speaklikeaking.com:
Removed file:
http://bugs.python.org/file33608/fix_tarfile_list_print_lone_surrogate_v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19920
Changes by Vajrasky Kok sky@speaklikeaking.com:
Added file:
http://bugs.python.org/file33610/fix_tarfile_list_print_lone_surrogate_v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19920
Vajrasky Kok added the comment:
Thanks, Serhiy, for your review. Here is the patch to address your concern.
--
Added file:
http://bugs.python.org/file33200/fix_tarfile_list_print_lone_surrogate_v2.patch
___
Python tracker rep...@bugs.python.org
Vajrasky Kok added the comment:
Here is the preliminary patch.
--
keywords: +patch
nosy: +vajrasky
Added file:
http://bugs.python.org/file33173/fix_tarfile_list_print_lone_surrogate.patch
___
Python tracker rep...@bugs.python.org
New submission from Serhiy Storchaka:
TarFile.list() fails on some files. In particular on Lib/test/testtar.tar.
import tarfile
tarfile.open('Lib/test/testtar.tar').list()
?rw-r--r-- tarfile/tarfile 7011 2003-01-06 01:19:43 ustar/conttype
?rw-r--r-- tarfile/tarfile 7011
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19920
___
___
15 matches
Mail list logo
