[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) <= sizeof(long)

Christian Heimes added the comment: The issue has been languishing for 8 years. I'm closing it as "fixed". -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file29071/posix_uid_gid_conv_signed_long_long.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: Auxiliary conversion functions for uid_t and gid_t was added in issue4591. They are supports unsigned types not larger than unsigned long. If someone need the support of the platform with signed uid_t/gid_t or with uid_t/gid_t larger than long (I don't know

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Antoine Pitrou added the comment: I think the patch will break on Unix systems that don't have uid_t or gid_t types. Do these exist? uid_t and gid_t are part of POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html --

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

STINNER Victor added the comment: On some OSes and combination of 64bit typess and 32bit long it's an invalid assumption. Can you give an example of OS where pid_t, gid_t or uid_t type are longer than the long type? (If I remember correctly, the identifier of a Windows process is an

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Trent Nelson tr...@snakebite.org: -- nosy: +trent ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___ Python-bugs-list mailing

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Martin v. Löwis added the comment: I think the patch will break on Unix systems that don't have uid_t or gid_t types. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Ronald Oussoren added the comment: The patch should work on OSX, although I haven't actually tested it yet. I've verified that sizeof(uid_t) and sizeof(gid_t) are the same for x86_64 and i386, which means SIZEOF_UID_T doesn't have to be added to pymacconfig.h. A smal nit with the patch: it

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file27926/posix_uid_gid_conv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: I think the patch will break on Unix systems that don't have uid_t or gid_t types. I think defines to int will be used on such systems. As I understand the configure script. A smal nit with the patch: it uses long long as a type instead of

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: Here is a patch that introduces four private function for convert an integer to uid_t/gid_t and back, and consistently apply these functions in all cases of uid_t/gid_t conversions. This should fix this issue and issues 4591, 7365, 15301, and a part of

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: See also issue4591, issue7365, issue15301, and issue15989. Kimmo Mustonen, if you are not working on the patch, I'll take the work. I don't want to interrupt your work, but if you are having trouble, maybe I can do it. In any case, I have already spent

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Kimmo Mustonen added the comment: Feel free to finalize this. I don't have such a system to test it anyway. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Petri Lehtinen added the comment: Serhiy Storchaka wrote: This can be done in compile time. Something like: if ((uid_t)-1 0) ... Ah, neat. I would have expected that to issue a compiler warning, though, because the comparison is always true if the type is unsigned, but at least gcc

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Christian Heimes added the comment: AFAIK C89 doesn't specify integer overflows: If an exceptional condition occurs during the evaluation of an expression (that is, if the result is not mathematically defined or not in the range of representable values for its type), the behavior is

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Petri Lehtinen added the comment: Christian Heimes wrote: AFAIK C89 doesn't specify integer overflows: Casting a signed integer to an unsigned integer is always defined, if that's what you're talking about. See http://flash-gordon.me.uk/ansi.c.txt, section 3.2.1.2. If you're talking about

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Petri Lehtinen added the comment: Checking whether a type is unsigned in configure.ac might be cumbersome... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: Checking whether a type is unsigned in configure.ac might be cumbersome... This can be done in compile time. Something like: if ((uid_t)-1 0) ... -- ___ Python tracker rep...@bugs.python.org

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Petri Lehtinen added the comment: Yeah, it seems that uid_t and gid_t can be signed or unsigned, while pid_t is always signed. Serhiy: What do you suggest? -- nosy: +petri.lehtinen ___ Python tracker rep...@bugs.python.org

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: I suggest use PyLong_AsLongAndOverflow/PyLong_AsLongLongAndOverflow and then PyLong_AsUnsignedLong/PyLong_AsUnsignedLongLong in case if positive overflow. Perhaps you need also special converters for O format in PyArg_ParseTuple. This issue is not as easy

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: Of course PyLong_AsUnsignedLong* should be used only if the type is unsigned. In such case any negative values except -1 are invalid. -- keywords: -easy ___ Python tracker rep...@bugs.python.org

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___ Python-bugs-list

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Kimmo Mustonen added the comment: Tried to fix uid/gid issues but I didn't have a system with uid/gid larger than long so wasn't able to verify the fix. -- keywords: +patch nosy: +tzimmo Added file: http://bugs.python.org/file27678/issue2005_py3.patch

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Serhiy Storchaka added the comment: uid_t and gid_t converters can not be just typedefs. uid_t and gid_t can be unsigned integral types (but including -1). Also should be fixed Modules/grpmodule.c, Modules/pwdmodule.c and Modules/signalmodule.c. --

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___ Python-bugs-list

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___ ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

R. David Murray rdmur...@bitdance.com added the comment: It appears as though this was fixed as part of issue 1983. Antoine, can you confirm that? -- nosy: +pitrou, r.david.murray -BreamoreBoy versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6, Python 3.0

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Antoine Pitrou pit...@free.fr added the comment: The pid_t issue was fixed but not uid_t/gid_t. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005 ___

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Mark Lawrence breamore...@yahoo.co.uk added the comment: I'm assuming that this has never been implemented, am I correct? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

Daniel Diniz aja...@gmail.com added the comment: That would be issue 1983. -- dependencies: +Return from fork() is pid_t, not int nosy: +ajaksu2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2005

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) = sizeof(long)

New submission from Christian Heimes: The posix module except that a pid_t, uid_t and gid_t always fit into a long or can be parsed by i. On some OSes and combination of 64bit typess and 32bit long it's an invalid assumption. The code should use long long where available or at least do some